I used OpenJDK 11.0.6, didn't try OpenJDK 14. Maybe we should remove error prone for JDK > 11.
Emmanuel Le 29/05/2020 à 17:58, Clebert Suconic a écrit : > I have JDK 13 on my mac.. I just tried with the rebase and I got this: > > [ERROR] at > org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356) > > [ERROR] Caused by: java.lang.NoSuchMethodException: > com.sun.tools.javac.comp.Resolve.findIdent(com.sun.tools.javac.comp.Env,com.sun.tools.javac.util.Name,com.sun.tools.javac.code.Kinds$KindSelector) > > [ERROR] at java.base/java.lang.Class.getDeclaredMethod(Class.java:2476) > > [ERROR] at > com.google.errorprone.util.FindIdentifiers.findIdent(FindIdentifiers.java:98) > > [ERROR] ... 87 more > > [ERROR] -> [Help 1] > > On Fri, May 29, 2020 at 11:55 AM Emmanuel Hugonnet <[email protected]> > wrote: >> Yes, you should be able to build with both JDK 8 and 11. >> >> Emmanuel >> >> Le 29/05/2020 à 17:54, Clebert Suconic a écrit : >>> so, if we switched to JDK 11 on the CI, those would still work with >>> the trick you used? >>> >>> On Fri, May 29, 2020 at 11:39 AM Emmanuel Hugonnet <[email protected]> >>> wrote: >>>> I changed the way the classloaders where working with JDK 11 using the >>>> plateform classloader as the parent instead of null so that I could >>>> access the required modules. >>>> >>>> Emmanuel >>>> >>>> Le 29/05/2020 à 17:37, Clebert Suconic a écrit : >>>>> We should come back into this... >>>>> >>>>> >>>>> How did you fix the compatibility tests with JDK 11? do you need JDK 8 >>>>> to run the compatibility tests? >>>>> >>>>> On Fri, May 8, 2020 at 3:19 PM Emmanuel Hugonnet <[email protected]> >>>>> wrote: >>>>>> No relation to WildFly, just for the 'fun' of it and because switching >>>>>> my JAVA_HOME and PATH each time I wxanted to build was itching me too >>>>>> much ;) >>>>>> >>>>>> It can wait and get some baking :) >>>>>> >>>>>> Emmanuel >>>>>> >>>>>> >>>>>> Le 08/05/2020 à 19:47, Clebert Suconic a écrit : >>>>>>> Oh wow.. that's awesome. >>>>>>> >>>>>>> >>>>>>> Can we do the migration after the 2.13.0 release? I have pretty much >>>>>>> everything ready to go (besides a few changes we have to make next >>>>>>> week). doing this migration now would probably delay the release. >>>>>>> >>>>>>> >>>>>>> Or you have some requirement for Wildfly that you must do this now? if >>>>>>> you do we can eventually delay it.. but I would prefer doing it for >>>>>>> later. >>>>>>> >>>>>>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <[email protected]> >>>>>>> wrote: >>>>>>>> Hello, >>>>>>>> >>>>>>>> When i need to work on Apache ActiveMQ Artemis I need to switch my >>>>>>>> local environement to use OpenJDK 8 instead of the default OpenJDK 11 >>>>>>>> which I use to develop. >>>>>>>> >>>>>>>> I have started a branch >>>>>>>> https://github.com/ehsavoie/activemq-artemis/tree/java_11 which builds >>>>>>>> on OpenJDK 8 and 11 with the fast-tests profile. >>>>>>>> >>>>>>>> mvn clean install -Pfast-tests is passing for me locally :) >>>>>>>> >>>>>>>> I don't think that the CI or the release should use Java 11 but I hope >>>>>>>> this will smoothen the time when the migration occurs. >>>>>>>> >>>>>>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of the >>>>>>>> use of Unsafe, if someone has a better alternative I'm all hears. >>>>>>>> >>>>>>>> Do you want me to sumbit a PR for this ? Does this make sense to the >>>>>>>> community ? >>>>>>>> >>>>>>>> Emmanuel >>>>>>>> >>>>>>>> >>>>>>>> >
signature.asc
Description: OpenPGP digital signature
