Thanks
Le 05/06/2020 à 16:51, Robbie Gemmell a écrit : > Building the javadoc wouldnt work for me on OpenJDK 11, probably for > the reasons I covered at > https://github.com/apache/activemq-artemis/pull/3161#issuecomment-638789127 > > I have since prepared fixes for all the errors however to now get it > to do so. They build on Emmanuel's changes a little so I wont raise a > PR until those are in: > https://github.com/gemmellr/activemq-artemis/tree/java11_javadoc > > On Wed, 3 Jun 2020 at 19:57, Clebert Suconic <[email protected]> > wrote: >> I am able to build with adoptopenjdk 11, but not with 13. a lot of >> errors on javadoc. >> >> We would need to fix those to be able to be flexible enough? or is >> there any magic settings perhaps to relax this? >> >> On Wed, Jun 3, 2020 at 6:16 AM Robbie Gemmell <[email protected]> >> wrote: >>> Going back to the error-prone dep being added to all the modules, if >>> those need to stay I think it would be good for the scope+optional >>> elements be added as well? I see its being governed in the >>> dependencyManagement addition, but the various modules appear to have >>> those elements for their existing dependency entries (e.g see the >>> immediate diff context for almost all the additions) so its a bit >>> inconsistent to omit them here. >>> >>> On Tue, 2 Jun 2020 at 18:23, Clebert Suconic <[email protected]> >>> wrote: >>>> that's cool.... >>>> >>>> we should move forward then! >>>> >>>> On Tue, Jun 2, 2020 at 1:19 PM Emmanuel Hugonnet <[email protected]> >>>> wrote: >>>>> error-prone 2.4.0 has been released with JDK 14 and 15 support. >>>>> >>>>> This might answer your question :) >>>>> >>>>> Emmanuel >>>>> >>>>> Le 02/06/2020 à 18:31, Clebert Suconic a écrit : >>>>>> But I think it should be on anything 11+ >>>>>> >>>>>> I would rather avoid having to re-address this again in the future, >>>>>> and be generic enough. >>>>>> >>>>>> >>>>>> What's holding the build on JDK 13? is it error prone for sure or >>>>>> something else? >>>>>> >>>>>> On Tue, Jun 2, 2020 at 5:56 AM Emmanuel Hugonnet <[email protected]> >>>>>> wrote: >>>>>>> Hello, >>>>>>> >>>>>>> I' ve updated my branch and rebased on current master from clebert's >>>>>>> branch. >>>>>>> >>>>>>> It passes a simple build on java 11.0.6 >>>>>>> >>>>>>> Cheers, >>>>>>> >>>>>>> Emmanuel >>>>>>> >>>>>>> Le 08/05/2020 à 19:47, Clebert Suconic a écrit : >>>>>>>> Oh wow.. that's awesome. >>>>>>>> >>>>>>>> >>>>>>>> Can we do the migration after the 2.13.0 release? I have pretty much >>>>>>>> everything ready to go (besides a few changes we have to make next >>>>>>>> week). doing this migration now would probably delay the release. >>>>>>>> >>>>>>>> >>>>>>>> Or you have some requirement for Wildfly that you must do this now? if >>>>>>>> you do we can eventually delay it.. but I would prefer doing it for >>>>>>>> later. >>>>>>>> >>>>>>>> On Fri, May 8, 2020 at 6:24 AM Emmanuel Hugonnet <[email protected]> >>>>>>>> wrote: >>>>>>>>> Hello, >>>>>>>>> >>>>>>>>> When i need to work on Apache ActiveMQ Artemis I need to switch my >>>>>>>>> local environement to use OpenJDK 8 instead of the default OpenJDK 11 >>>>>>>>> which I use to develop. >>>>>>>>> >>>>>>>>> I have started a branch >>>>>>>>> https://github.com/ehsavoie/activemq-artemis/tree/java_11 which >>>>>>>>> builds on OpenJDK 8 and 11 with the fast-tests profile. >>>>>>>>> >>>>>>>>> mvn clean install -Pfast-tests is passing for me locally :) >>>>>>>>> >>>>>>>>> I don't think that the CI or the release should use Java 11 but I >>>>>>>>> hope this will smoothen the time when the migration occurs. >>>>>>>>> >>>>>>>>> Also I couldn't use the --release 8 flag for OpenJDK 11 because of >>>>>>>>> the use of Unsafe, if someone has a better alternative I'm all hears. >>>>>>>>> >>>>>>>>> Do you want me to sumbit a PR for this ? Does this make sense to the >>>>>>>>> community ? >>>>>>>>> >>>>>>>>> Emmanuel >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>> >>>> -- >>>> Clebert Suconic >> >> >> -- >> Clebert Suconic
signature.asc
Description: OpenPGP digital signature
