-1 (non-binding) The zip has similar permission issues seen on prior NMS related candidates when extracting on Linux, meaning you can extract the zip but then can't simply delete the resulting content (which would again be easier if contained in a subdir).
The LICENCE file looks to include various cruft it shouldn't (in particular various Java stuff sticks out, plus there are multiple needless copies of the ALv2...seems like a lot of this isnt NMS relevant). The NOTICE file needs its years updated, component name fixed, the silly header removed, and perhaps the content looked at for accuracy (is that referenced component actually included, not clear it is?) I also dont see a tag relating to the vote. There were some release-related source changes made in the source repo after the archives were added to dist dev area, though I think those were in the archive? They'd need to be if required to recreate the release bits. A tag should exist for whats in it either way. Robbie On Sun, 16 Aug 2020 at 18:36, Havret <[email protected]> wrote: > > Hi All, > > I have put together a release of activemq-nms-openwire, please > check it and vote accordingly. > > This release brings .NET Standard 2.0 support. > > The files can be grabbed from: > https://dist.apache.org/repos/dist/dev/activemq/activemq-nms-openwire/1.8.0-rc1/ > > Regards, > Krzysztof
