Hi, Thanks, just commented on the PR: I already had quite the same fix ready (as I said previously on this thread).
I revert my local change to take yours. Regards JB > Le 20 avr. 2021 à 21:05, Jonathan Gallimore <[email protected]> a > écrit : > > I opened a PR for AMQ-8220: https://github.com/apache/activemq/pull/650. > > Tested with Java 11 and 16 on Mac. Will also test on Windows with the same. > > Jon > > On Tue, Apr 20, 2021 at 2:10 PM Christopher Shannon < > [email protected]> wrote: > >> I think just AMQ-8220 which if not an easy fix I think could wait until >> 5.16.3 so we can get it out. >> >> On Tue, Apr 20, 2021 at 9:05 AM Jonathan Gallimore < >> [email protected]> wrote: >> >>> Is there anything blocking a 5.16.2 release that anyone could help out >>> with? Happy to try and help. >>> >>> Jon >>> >>> On Tue, Apr 20, 2021 at 2:03 PM Christopher Shannon < >>> [email protected]> wrote: >>> >>>> Just to clarify, I'm not saying to cancel this vote for 5.16.2, I think >>>> it's ok to have both. Doing the releases simultaneously and announcing >>>> together makes sense to me and I will happily vote +1 on both if >>> everything >>>> checks out. I just don't think it's a good idea to wait on 5.16.2 at >> this >>>> point and do 5.15.15 first for the reasons discussed previously. >>>> >>>> >>>> >>>> On Tue, Apr 20, 2021 at 7:39 AM Christopher Shannon < >>>> [email protected]> wrote: >>>> >>>>> I will -1 this unless a 5.16.2 vote is also started shortly. >>>>> >>>>> We have now had numerous discussions about why 5.16.2 should be >>> released >>>>> first and you have agreed to do it first now on multiple occasions. >>>> Robbie >>>>> has made this point several times. The reason we did not do it before >>>> was a >>>>> blocker with redelivery that is now fixed. Waiting for JDK 16 support >>> is >>>>> not a reason to hold up 5.16.2 as it can go into 5.16.3. Or it can >> just >>>> be >>>>> done first and then do 5.16.2. >>>>> >>>>> The priority for releases needs to be the latest which is the 5.16.x >>>>> branch. >>>>> >>>>> On Tue, Apr 20, 2021 at 3:00 AM Jean-Baptiste Onofre < >> [email protected]> >>>>> wrote: >>>>> >>>>>> Hi everyone, >>>>>> >>>>>> I submit Apache ActiveMQ 5.15.15 to your vote (third attempt). We >>> fixed >>>>>> the issue identified in AMQ-8226 and this is a new take (#3) on >>> 5.15.15 >>>>>> release. >>>>>> >>>>>> This release includes important fixes and updates, especially: >>>>>> - Shiro, Spring, xstream, jetty upgrades >>>>>> - fixes on WebConsole when destination name contains + >>>>>> - fixes and improvements on the Karaf features to avoid breaking >> Karaf >>>>>> http commands and refresh >>>>>> - improved serialization security to avoid impact on xstream ack >>>>>> processing >>>>>> >>>>>> Please take a look on the Release Notes for details: >>>>>> >>>>>> >>>>>> The Maven staging repository is: >>>>>> >>>> >>> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1228/ >>>>>> < >>>>>> >>>> >>> >> https://repository.apache.org/content/repositories/orgapacheactivemq-1228/ >>>>>>> >>>>>> >>>>>> The dist staging repository is: >>>>>> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.15.15/ < >>>>>> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.15.15/> >>>>>> >>>>>> Git tag: >>>>>> activemq-5.15.15 >>>>>> >>>>>> Please vote to approve this release: >>>>>> >>>>>> [ ] +1 Approve the release >>>>>> [ ] -1 Don't approve the release (please provide specific comments) >>>>>> >>>>>> This vote will be open for at least 72 hours. >>>>>> >>>>>> Thanks ! >>>>>> Regards >>>>>> JB >>>>> >>>>> >>>> >>> >>
