I left some mostly trivial feedback on another PR merged yesterday, #3728, but there is one comment I think also needs looked at first: https://github.com/apache/activemq-artemis/pull/3728#discussion_r705417703
On Thu, 9 Sept 2021 at 15:26, Clebert Suconic <clebert.suco...@gmail.com> wrote: > > Let’s postpone until Monday while we investigate these. > > On Thu, Sep 9, 2021 at 9:01 AM Robbie Gemmell <robbie.gemm...@gmail.com> > wrote: > > > Franz believes he found the issue, side effects from an earlier change > > made months ago being hit now, exposed by use of the affected method > > in recent changes. > > https://issues.apache.org/jira/browse/ARTEMIS-3465 > > https://github.com/apache/activemq-artemis/pull/3731 > > > > I also think the issue noted in these comments should be investigated > > before another release occurs: > > https://github.com/apache/activemq-artemis/pull/3711#issuecomment-913981275 > > https://github.com/apache/activemq-artemis/pull/3711#issuecomment-914286613 > > https://github.com/apache/activemq-artemis/pull/3711#discussion_r699397216 > > > > On Thu, 9 Sept 2021 at 12:57, Robbie Gemmell <robbie.gemm...@gmail.com> > > wrote: > > > > > > Changes made on main recently (perhaps yesterday) look to have rather > > > broken some things on expanded test runs (i.e not the push/PR subset), > > > so that needs to be resolved first. > > > > > > On Wed, 8 Sept 2021 at 22:48, Clebert Suconic <clebert.suco...@gmail.com> > > wrote: > > > > > > > > Any problem if I did the release tomorrow? > > > > > > > > Anyone wants to include anything extra ? > > > > > > > > > > > > > > > > On Fri, Aug 20, 2021 at 3:10 PM Clebert Suconic < > > clebert.suco...@gmail.com> > > > > wrote: > > > > > > > > > I would like to do a 2.19.0 release around Aug-30th. > > > > > > > > > > > > > > > Please help me out on merging stuff required before then. > > > > > > > > > > > > > > > if there's something (JIRA or PR) you would really like to include > > > > > please mention it here.. (Last time someone mentioned me on the PR I > > > > > missed the notification). > > > > > > > > > > > > > > > > > > > > -- > > > > > Clebert Suconic > > > > > > > > > -- > > > > Clebert Suconic > > > -- > Clebert Suconic
