On Tue, 12 Jul 2022 at 20:52, Clebert Suconic <clebert.suco...@gmail.com> wrote: > > I would like to propose an ActiveMQ Artemis Native 2.0.0 release > > > For those who are not familiar, this is the Native Layer in Artemis > responsible for the integration on Linux and Libaio. > > > I have been working on some logging changes with Robbie Gemmel, and > Artemis Native 2.0.0 is now using SLF4J. This Module will be a > requirement for ActiveMQ Artemis to move forward with SLF4J. > > > > The source distribution is here: > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis-native/2.0.0/ > > > The Maven staged repository is here: > https://repository.apache.org/content/repositories/orgapacheactivemq-1257 > > > The git tag is here: > https://github.com/apache/activemq-artemis-native/releases/tag/2.0.0 > > > the release notes is here: > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12348395 > > > > > [ ] +1 approve this release > [ ] +0 no opinion > [ ] -1 disapprove (and reason why) > > > Here's my +1 binding > > > > > -- > Clebert Suconic
+1 I checked things out as follows: - Verified the signature + checksum files. - Checked for LICENCE + NOTICE files in the archive. - Checked licence headers in the source archive by running: "mvn apache-rat:check" - Ran the source build and tests on JDK 11 and 17 with: "mvn clean verify -Ppodman" and "mvn clean verify -Pdocker" I did notice 1 trivial non-blocking issue when running the RAT check, which worked but also caused a warning: There is an invalid pluginManagement entry from a c&p error (oops) that fails to resolve, and also means an older inherited version for the enforcer plugin is being used rather than the newer one originally intended. This isnt really much of an issue as the build continues and the older enforcer still happens to work (some intermediate versions between the two would not have) for the current uses which is why it wasnt noticed before. The only real consequence I've seen is the warning emitted about the invalid entry if you happen to trigger resolving the pluginManagement entry as the RAT check did. I have already fixed the cause on main at https://github.com/apache/activemq-artemis-native/commit/f1502e2855eab8bae2730da4aaa2a33b7dfdbd75 Robbie
