I think that's fair. +1
Justin On Thu, Sep 22, 2022 at 2:58 PM Clebert Suconic <clebert.suco...@gmail.com> wrote: > I am following up with an item that will be part of the document > upload on the release notes: > > https://github.com/apache/activemq-artemis/pull/4229 > > > > Rest as I said it's a maven dependency. There's no point in keeping it > as it can be accessed from a previous maven repository. > > > @Justin Bertram If you can move your vote to +1 based on this, I would > appreciate it.. but I think we are still proceeding with the release. > > > On Thu, Sep 22, 2022 at 3:49 PM Clebert Suconic > <clebert.suco...@gmail.com> wrote: > > > > and it turns out activeMQ Artemis Rest is not part of the > > distribution... (I don't think it's ever been). > > > > it's a component that you consume from maven and you have to create > > your own war with your dependency. > > > > > > in these terms the current REST would work as is as long as you use it > > from a previous version... > > > > > > > > I will update the release notes with instructions on how to use Rest > > from a previous version. > > > > On Thu, Sep 22, 2022 at 3:16 PM Clebert Suconic > > <clebert.suco...@gmail.com> wrote: > > > > > > The ActiveMQ Artemis Rest module itself is being pretty much > > > abandonware and no one wants to fix it... > > > > > > To fix it we would need to bring a few versions up to date.. and make > > > some improvements on the module. > > > > > > > > > > > > People can still use the Rest from any previous download of artemis. > > > Just bring the WAR from a previous version... > > > > > > > > > I will add a note on the release notes on how to do it... > > > > > > > > > > > > And I'm not against fixing it and keeping it.. as long as it become > > > active and fixed.... but I don't see anyone stepping up for it... > > > > > > > > > On Thu, Sep 22, 2022 at 2:57 PM Havret <h4v...@gmail.com> wrote: > > > > > > > > I may be a bit ignorant here (not a java dev), but how changing the > logging > > > > framework may justify and imply removing the whole functional module? > > > > > > > > On Thu, Sep 22, 2022 at 8:55 PM Clebert Suconic < > clebert.suco...@gmail.com> > > > > wrote: > > > > > > > > > We can put a release notes on how to bring the rest from a previous > > > > > version and still install in the current release... noticing this > > > > > won't be supported in future releases. > > > > > > > > > > > > > > > > > > > > And if you prefer to keep the module, just update the module and > bring > > > > > it back please. This release should progress I think. @Justin > would > > > > > you consider changing it to +1? > > > > > > > > > > On Thu, Sep 22, 2022 at 2:44 PM Clebert Suconic > > > > > <clebert.suco...@gmail.com> wrote: > > > > > > > > > > > > if you want to keep that Rest, please fix it (update jboss-rest) > and > > > > > > then move it back. > > > > > > > > > > > > > > > > > > Especially we are removing jboss-logging, and that rest > implementation > > > > > > is strongly dependent on jboss-logging. > > > > > > > > > > > > On Thu, Sep 22, 2022 at 2:07 PM Justin Bertram < > jbert...@apache.org> > > > > > wrote: > > > > > > > > > > > > > > -1 (binding) > > > > > > > > > > > > > > I just responded on the [DISCUSS] thread about removing the > REST > > > > > interface. > > > > > > > As far as I can tell the REST interface is perfectly > functional. I > > > > > think we > > > > > > > should deprecate it and update the documentation with an > explanation > > > > > before > > > > > > > removing it completely. > > > > > > > > > > > > > > > > > > > > > Justin > > > > > > > > > > > > > > On Wed, Sep 21, 2022 at 3:34 PM Clebert Suconic < > > > > > clebert.suco...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > I would like to propose an Apache ActiveMQ Artemis 2.26.0 > release. > > > > > > > > > > > > > > > > > > > > > > > > We removed ActiveMQ Artemis Rest, (which was already non > functional) > > > > > > > > as part of this release. > > > > > > > > And other improvements and bug fixes. > > > > > > > > > > > > > > > > > > > > > > > > The release notes can be found here: > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12352297&projectId=12315920 > > > > > > > > > > > > > > > > Ths git commit report is here: > > > > > > > > > > > > > > > > > > > > > > https://activemq.apache.org/components/artemis/download/commit-report-2.26.0 > > > > > > > > > > > > > > > > Source and binary distributions: > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/2.26.0 > > > > > > > > > > > > > > > > The Maven repository is here: > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1262 > > > > > > > > > > > > > > > > > > > > > > > > In case you want to give it a try with the maven repo on > examples: > > > > > > > > > > > > > > > > > > > > > > https://activemq.apache.org/components/artemis/documentation/hacking-guide/validating-releases.html > > > > > > > > > > > > > > > > The source tag is 2.26.0 on git, commit > > > > > > > > 2d7b1a3ef7613dab68aeeb667f5b5eca37743b94: > > > > > > > > > https://github.com/apache/activemq-artemis/releases/tag/2.26.0 > > > > > > > > > > > > > > > > The source tag: > > > > > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf/activemq-artemis.git;a=tag;h=refs/tags/ > > > > > > > > <version> > > > > > > > > > > > > > > > > > > > > > > > > I will update the website after the vote has passed. > > > > > > > > > > > > > > > > > > > > > > > > [ ] +1 approve this release > > > > > > > > [ ] +0 no opinion > > > > > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > > > > > > > Here is my +1 Binding vote > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Clebert Suconic > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Clebert Suconic > > > > > > > > > > > > > > > > > > > > -- > > > > > Clebert Suconic > > > > > > > > > > > > > > > > > -- > > > Clebert Suconic > > > > > > > > -- > > Clebert Suconic > > > > -- > Clebert Suconic > >
