Thanks a lot.. I see that now.. nice idea and it worked
The upgrade command is working. The command now is always replacing everything but the instances , data and other things... The upgrade command will look for a set of prefixes to keep from the current file, and bix with the new version. Notice that I am always replacing the JAVA_OPTS and the user will have to provide the memory settings and eventually extra java-opts during the upgrade. I have the code and tests finished now.. and I will need to review the docs (upgrade, versions.. and see if I can add anything tomorrow on the docs). So everything but docs is ready on this PR now: https://github.com/apache/activemq-artemis/pull/4246 also notice I am parsing the etc location from the binary (windows or Unix). On Wed, Nov 2, 2022 at 8:51 AM Robbie Gemmell <[email protected]> wrote: > > https://maven.apache.org/plugins/maven-resources-plugin/examples/filter.html > is a common way of filtering resources with maven, and perhaps the > simplest fit in the case as I understand it. > > The website module's documentation build also has an example of > substituting stuff in the docs using the antrun plugin. > > On Wed, 2 Nov 2022 at 02:15, Clebert Suconic <[email protected]> > wrote: > > > > I will need another day to finish the upgrade thing... > > > > > > Also, there's a bug in the current main (independent of what I'm > > changing). if you use a custom ./etc the management.xml is not being > > found.. and I will fix as part of the whole thing.. and also add a > > test. > > > > > > We will need the release for at least until Thursday..I think we will > > finish by tomorrow. > > > > > > meanwhile if anyone knows a good way to copy files while applying a > > search / replace pattern in maven that would be a great help.. that > > would help me with my test... > > > > > > thank you.. > > > > On Fri, Oct 28, 2022 at 6:11 PM Clebert Suconic > > <[email protected]> wrote: > > > > > > We should finish https://github.com/apache/activemq-artemis/pull/4246 > > > before we do a release. > > > > > > > > > We should probably update the upgrade nodes with the new ./artemis > > > upgrade command.. .which I will do next week... but I would appreciate > > > any feedback so we can finish it before we release. > > > > > > On Mon, Oct 24, 2022 at 4:36 PM Justin Bertram <[email protected]> > > > wrote: > > > > > > > > I would like to put Artemis 2.27.0 up for vote next week mainly due to > > > > CVE-2022-42889 [1] [2]. Please send any PRs you want in this release > > > > ASAP. > > > > > > > > > > > > Justin > > > > > > > > [1] https://nvd.nist.gov/vuln/detail/CVE-2022-42889 > > > > [2] https://issues.apache.org/jira/browse/ARTEMIS-4060 > > > > > > > > > > > > -- > > > Clebert Suconic > > > > > > > > -- > > Clebert Suconic -- Clebert Suconic
