Sounds good, I think it's ready to go as anything that needs fixing shouldn't be major and we have time to fix stuff in follow on PRs.
It would be good to get 5.19.0 released before too long so it fixes compatibility with Spring 6 and Spring boot 3. When we do release it will be important to have that release page and notes with detailed information about the goal of 5.19.0 and exactly what it does and doesn't support in terms of the Jakarta spec. On Tue, Aug 29, 2023 at 9:42 AM Matt Pavlovich <mattr...@gmail.com> wrote: > Hey Chris— Thanks for the review. > > I’ll plan to merge the PR this evening and get started on other tasks > ahead of release. > > Thanks, > Matt Pavlovich > > > On Aug 28, 2023, at 5:33 PM, Christopher Shannon < > christopher.l.shan...@gmail.com> wrote: > > > > I'm wrapping up my testing now, I've done a lot of thorough testing with > my > > own custom test suite and things are looking pretty good. > > > > Assuming all my tests look good I will approve the PR shortly and I > figure > > we should give it a couple more days and just go ahead and merge the PR > if > > there are no comments as it's been open for a long time. > > > > There will still be time to make any updates/fixes in follow on PRs > before > > releasing 5.19.0 (such as fixing OpenWire generation and any OSGi fixes) > > > > On Thu, Aug 24, 2023 at 6:13 PM Matt Pavlovich <mattr...@gmail.com> > wrote: > > > >> Hey All- > >> > >> Heads up— the PR for Jakarta support for the ActiveMQ 5.x broker is in > >> final review. > >> > >> There are a lot of notes in the PR ticket itself. I suggest scrolling > down > >> to the ‘reviewer checklist’ to see the 100 or so files that actually had > >> some code change vs the 1,400+ or so files that have only namespace > changes. > >> > >> https://github.com/apache/activemq/pull/996 > >> > >> Thanks! > >> Matt Pavlovich > >
