+1 non-binding Thanks, Ken
On Sun, Nov 10, 2024 at 10:55 PM Jamie G. <jamie.goody...@gmail.com> wrote: > +1 > > Cheers, > Jamie > > On Fri, Nov 8, 2024 at 11:06 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > > Hi Matt > > > > I fixed AMQ-9549: the issue is a duplicate, the reporter closed the > > issue without removing the fix versions. It's ok now. > > > > For AMQ-9530, I agree with you and you have a good point. As discussed > > together on Slack, starting from now, we will be more strict in > > semantic versioning and changes in release. > > We used to be more "flexible" but you are right, we should be more > consistent. > > > > I take the point and keep in mind for future releases. > > > > Regards > > JB > > > > On Fri, Nov 8, 2024 at 10:51 PM Matt Pavlovich <mattr...@gmail.com> > wrote: > > > > > > Hey JB- > > > > > > This change is in the release notes, but is not in the release: > > > [AMQ-9549 <https://issues.apache.org/jira/browse/AMQ-9549>] - > [Missing JMS 2.0 / JMS 3.1 feature] Add support for sending messages > asynchronously using jakarta.jms.CompletionListener > > > > > > A couple things about this change: > > > [AMQ-9530 <https://issues.apache.org/jira/browse/AMQ-9530>] - > ClassCastException in SelectorAwareVirtualTopicInterceptor if there is > another interceptor > > > > > > This change still has an unused Optional import that should be fixed > (not release stopping, but should have fix PR ASAP) > > > > > > Regarding AMQ-9530, this is only a bug to a newly reported use case. > This issue does not break existing users, and risks breaking existing users > since it is a refector of a SPI extension point — this really should be in > a minor patch release (v6.2.x) instead of v6.1.x per SEMVER going forward. > > > > > > I’m all for keeping things moving, but we need to be diligent in > ensuring users can trust that patch release do not break their builds. I > will probably -1 this type of change in a patch release in the future. > > > > > > Thanks, > > > Matt Pavlovich > > > > > > > On Nov 8, 2024, at 5:06 AM, Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > > > > > > > > Hi folks, > > > > > > > > I submit Apache ActiveMQ Classic 6.1.4 release to your vote. > > > > This release is a maintenance release on the 6.1.x series, including > > > > fixes and updates especially: > > > > - fix message corruption when using 4-byte Unicode message from JMS > to STOMP > > > > - prevent ClassCastException in SelectorAwareVirtualTopicInterceptor > > > > if there is another interceptor > > > > - fix KahaDB PageFile can call setLength() on the recovery file which > > > > always throws an exception > > > > - fix Durable subscriber receives acknowledge messages if they are > > > > farther than the maxBatchSize > > > > - ... a bunch of dependency updates > > > > > > > > You can take a look on Release Notes for detail: > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12354974 > > > > > > > > Staging Maven Repository: > > > > > https://repository.apache.org/content/repositories/orgapacheactivemq-1413/ > > > > > > > > Staging Dist Repository: > > > > https://dist.apache.org/repos/dist/dev/activemq/activemq/6.1.4/ > > > > > > > > Git tag: > > > > activemq-6.1.4 > > > > > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > > > [ ] 0 I don't care > > > > [ ] -1 Don't approve the release (please provide specific comment) > > > > > > > > This vote will be open for at least 72 hours. > > > > > > > > Thanks! > > > > Regards > > > > JB > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > > > > For additional commands, e-mail: dev-h...@activemq.apache.org > > > > For further information, visit: https://activemq.apache.org/contact > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > > For additional commands, e-mail: dev-h...@activemq.apache.org > > For further information, visit: https://activemq.apache.org/contact > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org > For additional commands, e-mail: dev-h...@activemq.apache.org > For further information, visit: https://activemq.apache.org/contact > > >
