+1 and thanks JB

Le lun. 11 nov. 2024, 20:45, Samir Boudjebla <samboudje...@hotmail.com> a
écrit :

> +1 (non binding)
>
> Best regards,
> Sam
>
> > On Nov 11, 2024, at 11:08 AM, Christopher Shannon <
> christopher.l.shan...@gmail.com> wrote:
> >
> > +1 (binding)
> >
> > * Validated signatures and checksums
> > * Verified license and notice files in archives
> > * Checked source license headers with 'mvn apache-rat:check'
> > * Built from source and ran through several tests
> > * Ran the broker from the binary archive and exercised the web console
> >
> > I agree about being more careful with API changes in future updates. It's
> > already been implemented so not a big deal now, but we could have avoided
> > the issue by moving getBaseDestination() to a utility class and changed
> the
> > method to be static. That solves the issue of the bug without introducing
> > any new SPI changes or classes in the hierarchy. That would mean not
> being
> > able to override the impl but I doubt we'd need to in this case. So in
> the
> > future it would be good to consider if we even need to make SPI changes
> > like this.
> >
> >> On Mon, Nov 11, 2024 at 10:43 AM Francois Papon <
> >> francois.pa...@openobject.fr> wrote:
> >>
> >> +1 (non-binding)
> >>
> >> Thanks for the release!
> >>
> >> regards,
> >>
> >> François
> >> fpa...@apache.org
> >> francois.pa...@openobject.fr
> >>
> >>> Le 08/11/2024 à 12:06, Jean-Baptiste Onofré a écrit :
> >>> Hi folks,
> >>>
> >>> I submit Apache ActiveMQ Classic 6.1.4 release to your vote.
> >>> This release is a maintenance release on the 6.1.x series, including
> >>> fixes and updates especially:
> >>> - fix message corruption when using 4-byte Unicode message from JMS to
> >> STOMP
> >>> - prevent ClassCastException in SelectorAwareVirtualTopicInterceptor
> >>> if there is another interceptor
> >>> - fix KahaDB PageFile can call setLength() on the recovery file which
> >>> always throws an exception
> >>> - fix Durable subscriber receives acknowledge messages if they are
> >>> farther than the maxBatchSize
> >>> - ... a bunch of dependency updates
> >>>
> >>> You can take a look on Release Notes for detail:
> >>>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12354974
> >>>
> >>> Staging Maven Repository:
> >>>
> >>
> https://repository.apache.org/content/repositories/orgapacheactivemq-1413/
> >>>
> >>> Staging Dist Repository:
> >>> https://dist.apache.org/repos/dist/dev/activemq/activemq/6.1.4/
> >>>
> >>> Git tag:
> >>> activemq-6.1.4
> >>>
> >>> Please vote to approve this release:
> >>> [ ] +1 Approve the release
> >>> [ ] 0 I don't care
> >>> [ ] -1 Don't approve the release (please provide specific comment)
> >>>
> >>> This vote will be open for at least 72 hours.
> >>>
> >>> Thanks!
> >>> Regards
> >>> JB
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail:dev-unsubscr...@activemq.apache.org
> >>> For additional commands, e-mail:dev-h...@activemq.apache.org
> >>> For further information, visit:https://activemq.apache.org/contact
> >>>
> >>>
> >>
>

Reply via email to