aarushiibisht commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft-portal/pull/6#discussion_r414949602
##########
File path: README.md
##########
@@ -16,11 +16,18 @@ Airavata Managed File Transfer is a standalone service to
orchestrate data movem
```
./build_js.sh
```
-2. Run the server
+2. Run the server
```
python manage.py runserver
```
+
+ ```
+ cd apps/workspace
+
+ npm run serve
Review comment:
npm run serve is for development. Can you please remove this from readme
##########
File path:
airavata_mft/apps/workspace/static/airavata_mft_workspace/js/containers/Storage.vue
##########
@@ -1,11 +1,21 @@
<template>
<div id="storage">
- <div class="container">
+ <div class="container" style="margin-left:15rem;">
Review comment:
add the css in <style></style>
##########
File path: airavata_mft/templates/base.html
##########
@@ -1,14 +1,85 @@
{% load render_bundle from webpack_loader %}
<!DOCTYPE html>
-<head>
-
-</head>
{% block scripts %}
{% endblock scripts %}
{% render_bundle 'chunk-vendors' config='DEFAULT'%}
{% render_bundle 'app' config='DEFAULT'%}
-<body>
-<!-- TODO : header and side navigation bar" -->
-{% block app %}
-{% endblock app %}
-</body>
+
+{% load static %}
+
+<html lang="en">
+ <head>
+ <meta charset="utf-8">
+ <meta name="viewport" content="width=device-width, initial-scale=1,
shrink-to-fit=no">
+ <meta name="description" content="">
+ <meta name="author" content="">
+
+ <title>Airavata MFT</title>
+ <!-- Bootstrap CSS CDN -->
+ <link rel="stylesheet"
href="https://stackpath.bootstrapcdn.com/bootstrap/4.1.0/css/bootstrap.min.css";
integrity="sha384-9gVQ4dYFwwWSjIDZnLEWnxCjeSWFphJiwGPXr1jddIhOegiu1FwO5qRGvFXOdJZ4"
crossorigin="anonymous">
+ <!-- Custom styles -->
+ <link href="{% static 'base.css' %}" type="text/css" rel="stylesheet">
+ </head>
+
+ <body>
+ <nav class="navbar navbar-expand-lg navbar-light ">
+ <a class="navbar-brand" href="#">
+ AIRAVATA MFT
+ </a>
+ <div>
+ <div class = main>
+ <div class="form-group has-search">
+ <span class="fa fa-search form-control-feedback"></span>
+ <input type="text" class="form-control" placeholder="Search">
+ </div>
+ </div>
+ </div>
+ <div>
+ <a class="nav-link dropdown-toggle" href="#" id="navbarDropdownMenuLink"
data-toggle="dropdown" aria-expanded="false">User</a>
+ </div>
+ </div>
+ </nav>
+ <div class="container-fluid" style="margin-top: :15rem;">
Review comment:
add style in base.css or within <style>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
