aarushiibisht commented on a change in pull request #6:
URL: https://github.com/apache/airavata-mft-portal/pull/6#discussion_r415572329
##########
File path: airavata_mft/templates/base.html
##########
@@ -1,14 +1,85 @@
{% load render_bundle from webpack_loader %}
<!DOCTYPE html>
-<head>
-
-</head>
{% block scripts %}
{% endblock scripts %}
{% render_bundle 'chunk-vendors' config='DEFAULT'%}
{% render_bundle 'app' config='DEFAULT'%}
-<body>
-<!-- TODO : header and side navigation bar" -->
-{% block app %}
-{% endblock app %}
-</body>
+
+{% load static %}
+
+<html lang="en">
+ <head>
+ <meta charset="utf-8">
+ <meta name="viewport" content="width=device-width, initial-scale=1,
shrink-to-fit=no">
+ <meta name="description" content="">
+ <meta name="author" content="">
+
+ <title>Airavata MFT</title>
+ <!-- Bootstrap CSS CDN -->
Review comment:
Do not use bootstrap CDN. Instead include it in package.json file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
