Hi Saurav,

I would recommend that you stick to the current design, given the GSOC 
timeline. We can add accordions or tabs later.

However, please refactor to use a common date selector. I think that will be a 
good change.

Thanks,

Marcus

> On Aug 13, 2023, at 1:53 PM, saurav kumar jha <imsauravgaurav...@gmail.com> 
> wrote:
> 
> Hi Marcus,
> Thanks a lot for your review and comments.
> 
> I agree that the page will become longer gradually and I think accordions 
> would be intuitive for users. Should I go ahead and put each of the 
> statistics in accordions?
> 
> I agree with you about having a common date selector for all stats, I will 
> make changes in my pull request accordingly.
> 
> No, I didn't think much about UX design till now. I followed the current 
> design of the portal.
> 
> Thanks & Regards,
> Saurav Kumar Jha
> 
> On Fri, Aug 11, 2023 at 3:57 AM Christie, Marcus Aaron <machr...@iu.edu> 
> wrote:
> Hi Saurav,
> 
> I've reviewed your pull request and it looks good to me.
> 
> One concern I have is with the UI layout. I think with this many forms it 
> will make the statistics page rather long. I wonder if maybe a tab-based 
> layout or an accordion style layout might work better?
> 
> Another concern is that the date filtering is repeated for each of these 
> statistics views. I wonder, why not just have them all utilize the main date 
> range?
> 
> Are you working from a UX design?
> 
> Thanks,
> 
> Marcus
> 
> > On Aug 3, 2023, at 12:44 PM, saurav kumar jha <imsauravgaurav...@gmail.com> 
> > wrote:
> > 
> > Hi Community,
> > 
> > I am updating my commits for AIRAVATA-3594 on django-portal in this pull 
> > request .
> > Any Comments or Recommendations will be very helpful.
> > 
> > Thanks & Regards,
> > Saurav Kumar Jha
> 

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to