Hello Airflow developers,

I just merged the initial version of pre-commit hooks to master of Airflow
with support for pylint, mypy, flake8, dockerfile linting (all the static
checks we had so far). This slightly changes the way how we run static
checks in Travis (one job for most static checks except pylint). More
static checks coming soon.

I encourage you to start using the hooks for your development cycle. If you
had bad experience with pre-commits in the past (I had) - please revisit
it. We are using fantastic pre-commit hook framework that is very easy to
install and use. It boils down to:

   - 'pre-commit install` for pre-commit hook installation
   - 'pre-commit install -t pre-push' for pre-push hook installation

Best of all - once you install the hooks, you will hopefully never have to
see Travis failing with your pylint/mypy/flake8 problems. Those checks will
automatically run for all your commits (and they should be usually fast as
they only check the few files modified by your commit - not all of them).
Sometimes you will need to rebuild the images to run the tests - but this
should be rare event, it is very easy to do and you have guidance on how to
do it.

The documentation is here:
https://github.com/apache/airflow/blob/master/CONTRIBUTING.md#pre-commit-hooks

In case you have problems with the hooks you can always skip running them
by passing `--no-verify` flag or uninstalling them ('pre-commit uninstall').

Let me know if you have any questions/problems etc. Be aware I am currently
on holidays ;) and in the East Coast time zone, so I might be not
super-responsive .

J.

-- 

Jarek Potiuk
Polidea <https://www.polidea.com/> | Principal Software Engineer

M: +48 660 796 129 <+48660796129>
[image: Polidea] <https://www.polidea.com/>

Reply via email to