Thanks Ash for all the comments and for testing/reviewing :). Glad to have someone looking over such a big release. I would love others to take a look as well.
I already fixed the -py2-py3 problem (universal flag in setup.cfg replaced with python-tag=py3) I think none of the problems are "critical" enough to terminate the rc1 but since we are releasing 58 packages and getting the description right for all of them is right - I think I will prepare an rc2 today with those small changes - so if others could also take a look and have any comments - please let me know. I will cut an rc2 release late afternoon today/. J. On Mon, May 18, 2020 at 12:45 PM Ash Berlin-Taylor <a...@apache.org> wrote: > > > On May 18 2020, at 11:25 am, Jarek Potiuk <jarek.pot...@polidea.com> > wrote: > > >> > >> > >> > >> Back-ported apache-airflow-backport-providers-snowflake package for > >> Airflow 1.10.* > >> > >> I think it should say > >> > >> Back-ported apache-airflow-providers-snowflake package for Airflow > >> 1.10.* > >> > >> Why no backports ? I believe we agreed (between you Kaxil and myself: > > > https://lists.apache.org/thread.html/rd6943e2bd7ed30317e7b8aff1b8fd7ea02b871f3c7ff7ac9988e12c5%40%3Cdev.airflow.apache.org%3E > ) > > on using backport in the name of the package. This is to make it > > potentially different from the packages that we will (maybe) later > release > > for 2.0. > > I think we have now consistently 'apache-airflow-backport-providers-*' - > > everywhere: package names, names of files, PyPI project. Or maybe I > missed > > it somewhere and we have apache-airlfow-proviiders-* somewhere else? > > > Because you can't back-port a backport, it doesn't make sense. How about > this as a description > > Back-ported airflow.providers.snowflake.* modules for Apache Airflow > 1.10.* > > (I am talking about the "Summary" field in the build packages here. > Everything else in the readme is good.) > > > > > We don't publish `-src` archives for these releases, and we need to > >> > https://apache.org/legal/release-policy.html#what-must-every-release-contain > > > > > > We do: > > > https://dist.apache.org/repos/dist/dev/airflow/backport-providers/2020.5.20rc1/apache-airflow-backport-providers-2020.5.20rc1-source.tar.gz > > > > > > This is a single source file for the whole airflow (including all > > providers) and you can rebuild any of the packages from this single > source > > file. Do you think we should have this file repeated for every package ? > > They will be aways the same - to make sure that we can rebuild the > packages > > we really need release all airflow sources. > > > Oh I thought we called this `-src` so was failing to find it. Yeah, > that's probably fine given the scripts to build the specific > sub-packages are contained within that release. > > > > >> > >> You have signed the releases with a key email address under your > >> personal domain -- it would be greatly preferable if you signed the > >> releases with a key using your apache.org email address, please. (You > >> can add a new email address to the same key, I think). > >> > > > > Sure. I can do it :) > > > >> > >> Oh yes, there are the .whl files, sorry! And confirmed that python2.7 > >> doesn't let them get installed. > >> > > > > I think we can prevent the -py2 in the next release - I am reading > > appropriate PEPs now :) > > > > -ash > > > >> > >> -ash > >> > >> On May 18 2020, at 10:58 am, Ash Berlin-Taylor <a...@apache.org> wrote: > >> > >> > Nice one Jarek, looking forward to having this! > >> > > >> > However: > >> > > >> > -1 (but recoverable without cancelling the vote) > >> > > >> > There are no wheel files in the artifacts uploaded to apache SVN > (which > >> > per the ASF rules is strictly what we vote upon/release). PyPi is just > >> > how we all install it. > >> > > >> > Please upload the .whl files to > >> > > >> > >> > https://dist.apache.org/repos/dist/dev/airflow/backport-providers/2020.5.20rc1/ > >> too. > >> > > >> > Additionally, and this one might need the vote cancelling to fix: the > >> > wheel files on PyPi have a suffix of `-py2.py3-none-any.whl` but these > >> > files are not installable on Python 2, so that doesn't seem right. > (The > >> > metadata in PyPi does say 'py>=3.6' though. Odd. Is this okay? Is it > >> > fixable anyway? > >> > > >> > I will continue testing. > >> > > >> > -a > >> > > >> > On May 17 2020, at 11:44 pm, Jarek Potiuk <jarek.pot...@polidea.com> > >> wrote: > >> > > >> >> Hey all, > >> >> > >> >> I have cut Airflow Backport Providers 2020.5.20rc1. > >> >> > >> >> This email is calling a vote on the release, which will last for 72 > >> >> hours - > >> >> which means that it will end on 2020.05.21 1:00 am CEST. > >> >> > >> >> Consider this my (binding) +1. > >> >> > >> >> Airflow Backport Providers 2020.5.20rc1 are available at: > >> >> > >> > https://dist.apache.org/repos/dist/dev/airflow/backport-providers/2020.5.20rc1/ > >> >> > >> >> There are 58(!) provider packages released the first time. > >> >> > >> >> *apache-airflow-backport-providers-2020.5.20rc1-source.tar.gz* is a > >> source > >> >> release that comes > >> >> with INSTALL instructions. > >> >> > >> >> > >> > *apache-airflow-backport-providers-<PROVIDER>-2020.5.20rc1-bin.tar.gz* is > >> >> the binary Python "sdist" release. > >> >> > >> >> Public keys are available at: > >> >> https://dist.apache.org/repos/dist/release/airflow/KEYS > >> >> > >> >> Only votes from PMC members are binding, but members of the community > >> are > >> >> encouraged to test the release and vote with "(non-binding)". > >> >> > >> >> Please note that the version number excludes the `rcX` string, so > >> >> it's now > >> >> simply 2020.5.19. This will allow us to rename the artifact without > >> >> modifying > >> >> the artifact checksums when we actually release. > >> >> > >> >> Each of the packages contains detailed changelog. Here is the list of > >> links > >> >> to > >> >> the released packages and changelogs: > >> >> > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-apache-spark/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-dingding/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-postgres/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-cloudant/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-datadog/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-jenkins/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-apache-hdfs/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-docker/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-slack/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-opsgenie/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-pagerduty/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-microsoft-mssql/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-amazon/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-singularity/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-databricks/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-salesforce/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-yandex/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-microsoft-azure/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-imap/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-mongo/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-exasol/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-microsoft-winrm/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-facebook/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-apache-sqoop/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-vertica/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-hashicorp/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-discord/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-jira/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-presto/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-celery/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-apache-pig/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-elasticsearch/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-sqlite/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-email/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-zendesk/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-grpc/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-apache-druid/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-apache-cassandra/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-oracle/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-ssh/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-cncf-kubernetes/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-ftp/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-odbc/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-apache-pinot/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-segment/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-sftp/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-http/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-qubole/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-google/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-apache-hive/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-snowflake/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-openfaas/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-redis/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-apache-livy/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-samba/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-papermill/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-jdbc/2020.5.20rc1/ > >> >> > >> > https://pypi.org/project/apache-airflow-backport-providers-mysql/2020.5.20rc1/ > >> >> > >> >> Cheers, > >> >> > >> >> J. > >> >> > >> > > > > > > -- > > > > Jarek Potiuk > > Polidea <https://www.polidea.com/> | Principal Software Engineer > > > > M: +48 660 796 129 <+48660796129> > > [image: Polidea] <https://www.polidea.com/> > > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
