Prompted by a desire to refactor this feature's related code I kept encountering, I discovered that the feature had been largely broken for some time, so I went ahead and fixed it and refactored in PR #14595 <https://github.com/apache/airflow/pull/14595>. After some discussion in that PR and learning more about the feature, I decided that the better course of action might be to just remove the feature instead. I've opened PR #14601 <https://github.com/apache/airflow/pull/14601> to do that with this description:
After fixing and refactoring the "demo mode" feature in #14595, I feel that > it would be more productive to replace that PR with this one that removes > the feature instead. > > - It has very little documentation > > > - It has been largely broken for an unknown period of time without any > issue reports. I only encountered it because I wanted to refactor its > implementation. > > > - As illustrated by @ashb it doesn't do a really great job if someone > were to capture a screenshot from remote demonstration. > > > - As pointed out by @HaloKo4, only being able to activate it from the > config doesn't make it a very convenient feature that can easily be > enabled/disabled. > > If this is a feature people would like to see, I think it would be better > to see a new implementation proposed that addresses these shortcomings. I am very interested to know if there is anyone who uses this feature (presumably in an older non-broken version), and/or if anyone believes it is worth keeping in its current design? Other thoughts? Feel free to comment in this thread or on PR #14601 <https://github.com/apache/airflow/pull/14601>. If I don't hear anything in the next 3 days, I'll move ahead with the removal PR (#14601 <https://github.com/apache/airflow/pull/14601>) instead of the fix PR ( #14595 <https://github.com/apache/airflow/pull/14595>). https://www.timeanddate.com/worldclock/fixedtime.html?msg=%22demo+mode%22+feedback&iso=20210311T11&p1=414
