Thanks a lot, Jarek for the detailed verification and fixing some of them via PRs. Given its first release, it's really worth scrutinizing every part of it.
I'm not quite sure about putting version 2.0.0 in master, cause the master of the client is derived from the master of Airflow, which makes it in between the release of 2.0.1 - 2.1.0 of Airflow, so I was thinking of updating the version in the master to 2.1.0.dev (same as Airflow). So I created a branch (rc2) on the client where the APIs are an exact match to the Airflow-2.0.1 release and used version 2.0.0 for the client in that. About the source gz, I was unzipping it into a diff dir, but I can fix that issue by creating a subfolder with the release name, so it'll be similar to Airflow or providers. About README.md containing instructions installing from the master, I thought of updating it after releasing the first release and pointing it to PyPI instead of GitHub. About dev/README_RELEASE_CLIENT.md, I've it handy and used it to create the release, will raise a PR today to add that into the repo. On Sun, Apr 11, 2021 at 3:43 PM Jarek Potiuk <[email protected]> wrote: > Hello Sumit, > > I took a closer look, and this one is a -1 for me for now. > > * I tested signatures and checksums, they are all fine. GOOD > * the source file does not have the prefix (but it does not have a > folder either - see below). I think this one could pass, but it would be > great if it is changed in rc2 > * I installed and tested the client and it works. GOOD > * there are few more things left to make it really "official" (see below) > and I wanted to ask others for their input here as well. > > There are few things that I already submitted PRs for: > * https://github.com/apache/airflow-client-python/pull/7 - version in the > changelog was still v1.0.0 > * https://github.com/apache/airflow-client-python/pull/8 - there were a > few licences missing and .rat-excludes. When I checked the source with the > Apache RAT tool, few of the files were reported. I added appropriate > excludes for .gitignores (that on it's own would not be a reason for -1) > but there are a few files which I think need to have license - > requirements.txt and .openapi-generator-ignore likely should have one as > well (you need requirements to make package from sources so it should have > a licence) > * https://github.com/apache/airflow-client-python/pull/9 - updated test > code with appropriate instructions - i just made it crystal-clear about the > config:auth_backend = airflow.api.auth.backend.basic_auth > > > There are a few points that I think should be added for rc2 (on top of the > PRs above) - happy to review/help with finalizing those: > > * the source .tgz should have a sub-folder "airflow-client-2.0.0rc1" - > previously it had a a file prefix that you removed, but what we really need > is a folder (similarly as we have in the airflow "sources") - otherwise > when we unpack it by default, it gets messy as it extracts all files in the > current folder > > * the README.md contains information on how to install the client via git > from the default branch. Since this is a user-facing instruction, I believe > it is against the rules of ASF to point the users to non-released, master > code (pip install git+https://github.com/apache/airflow-client-python.git), > We had similar discussion in other projects and I think the consensus is > that it is ok if you you point the users to a "stable" tag pointing to the > latest release and provide PyPI as convenience installation method. But > pointing to the master in a README is not good IMHO, but I would love to > hear what others think. This is another reason for -1 from me. This has > serious legal implications (PMCs are supposed to vote for every such > release advertised to the users). > > * I believe we need a dev/README_RELEASE_CLIENT.md - similar to > https://github.com/apache/airflow/blob/master/dev/README_RELEASE_AIRFLOW.md > (you can take it as a base) where we have a description of the release > process. It is necessary to make it repeatable so that anyone can do it. > There we also need to have a description about adding TAG to the release > (and potentially moving the 'stable") tag when the final release is made. > > > > > On Thu, Apr 8, 2021 at 10:02 AM Sumit Maheshwari <[email protected]> > wrote: > >> I think I've used an extra prefix while preparing the tar, fixed it now. >> Please check. >> >> TIA. >> >> On Thu, Apr 8, 2021 at 1:06 PM Sumit Maheshwari <[email protected]> >> wrote: >> >>> Seems weird. Thanks for letting me know, checking it now. >>> >>> On Thu, Apr 8, 2021 at 2:30 AM Jarek Potiuk <[email protected]> wrote: >>> >>>> Hey Sumit, >>>> >>>> I think there is a problem with source package. When you uncompress it, >>>> you have a bunch of files and directories starting >>>> with airflow-client-2.0.0rc1: >>>> >>>> airflow-client-2.0.0rc1license-templates/ >>>> airflow-client-2.0.0rc1airflow_client/ >>>> airflow-client-2.0.0rc1.github/ >>>> ... >>>> >>>> J. >>>> >>>> >>>> >>>> >>>> On Wed, Apr 7, 2021 at 2:34 PM Sumit Maheshwari <[email protected]> >>>> wrote: >>>> >>>>> Hello everyone, >>>>> >>>>> I have cut the first release candidate for the Airflow Python Client >>>>> 2.0.0rc1. The client consists of APIs corresponding to REST APIs available >>>>> in *Apache Airflow 2.0.1* release. This email is calling a vote on >>>>> the release, which will last for 72 hours. Consider this my (binding) +1. >>>>> >>>>> Airflow Client 2.0.0.rc1 is available at: >>>>> https://dist.apache.org/repos/dist/dev/airflow/clients/python/2.0.0rc1/ >>>>> >>>>> *airflow-client-2.0.0rc1-source.tar.gz* is a source release that >>>>> comes with INSTALL instructions. >>>>> *airflow-client-2.0.0rc1-bin.tar.gz* is the binary Python "sdist" >>>>> release. >>>>> >>>>> Public keys are available at: >>>>> https://dist.apache.org/repos/dist/release/airflow/KEYS >>>>> >>>>> Only votes from PMC members are binding, but the release manager >>>>> should encourage members of the community to test the release and vote >>>>> with >>>>> "(non-binding)". >>>>> >>>>> As this is the first release, there is no changelog. The source code >>>>> for this release can be found here: >>>>> https://github.com/apache/airflow-client-python/tree/r2.0 >>>>> >>>>> Thanks, >>>>> Sumit Maheshwari >>>>> PMC Apache Airflow >>>>> >>>> >>>> >>>> -- >>>> +48 660 796 129 >>>> >>> > > -- > +48 660 796 129 >
