Hi all committers and reviewers,
Let’s be more stricter for PR reviews. Some of the PRs have slipped by and
merged (I have been guilty too) that had breaking changes in the
last couple of versions which are now fixed but let's be more vigilant.
I propose the following guidelines (not rules):
- Ask for unit tests coverage wherever applicable
- Require at least 2 approvals for Core changes
- Be extra sensitive to DB migrations
- Verify the logic to confirm that it would not take an
unreasonable amount of time to run it - especially the ones containing
*task_instance* table.
- Use the utilities added in
https://github.com/apache/airflow/commit/7622f5e08261afe5ab50a08a6ca0804af8c7c7fe
to create migrations to avoid cases where for example we miss precisions
for datetime for MySQL - PR
<https://github.com/apache/airflow/pull/9336>.
- Ideally, each Migration should be idempotent.
- At least 1 minor release every 3 months so we don't diverge hugely
from the *main* branch
Thanks.
Regards,
Kaxil
