Hi Jarek,
Sounds great! I can also help to look into these new issues and fix. Regards, Khalid On 30/11/2021 12:14, Jarek Potiuk wrote:
Hey all, I created an issue for that here: https://github.com/apache/airflow/issues/19891 but wanted to get a lazy consensus on that one (I think it does not really need voting or consensus, but If there is anyone who wants to comment/object fill free). For a few weeks MyPy checks have been disabled after the switch to Python 3.7 (per https://github.com/apache/airflow/pull/19317). We should, however, re-enable it back as it is very useful in catching a number of mistakes. I am re-adding the mypy pre-commit now - with mypy bumped to 0.910. This version detects far more errors and we should fix them all before we switch the CI check back. The way I am bringing it back in https://github.com/apache/airflow/pull/19890: * mypy will be running for incremental changes in pre-commit, same as before. This will enable incremental fixes of the code changed by committers who use pre-commits locally * mypy on CI runs in non-failing mode. When the main pre-commit check is run, mypy is disabled, but then it is run as a separate step (which does not fail but will show the result of running mypy on all our code). This will enable us to track the progress of fixes We should make a concerted effort now and incrementally fix all the mypy incompatibilities - ideally package/by/package to avoid huge code reviews. I'd really appreciate a number of people to contribute, so that we can re-enable mypy back fully :). J.
