I really like the idea of having them all entirely separate and letting the user install which one(s) they want, there are a lot of good reasons for that which are already covered. I'll bring up one point that nags me about this change though. Airflow requires SOME executor. I agree we shouldn't care which, but I think maybe we might want to have a look at how we guide initial Airflow installation and configuration to make sure we are very clear that they can choose whichever they want, but they MUST choose at least one. I don't know if that would take the form of a GUI warning or a message in the install script or both or something else entirely, but if we go from preinstalling to manual install only, I can see that causing confusion.
- ferruzzi ________________________________ From: Jarek Potiuk <[email protected]> Sent: Friday, July 21, 2023 12:27 PM To: [email protected] Subject: RE: [EXTERNAL][DISCUSS] Should we pre-install celery/k8s providers? CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. FYI. I will hold on with the formal vote until we have a few more days for discussion. This is an easy change. J. On Fri, Jul 21, 2023 at 8:38 PM Daniel Standish <[email protected]> wrote: > > Yeah it ain't the easiest of decisions. > > @niko, when I think about the staged approach, it feels like it is maybe > more disruptive than doing it all at once. > > stage 1: force everyone to install k8s and celery libs -- that's one > disruption / risk > stage 2: remove pre-install -- another disruption > > it seems maybe better to do it all at once (if it's the ultimate goal). > > i suppose you could try to introduce a special deprecation warning after > stage 1 if user is using celery without having installed the package > explicitly. we might have to do some shenanigans to accomplish that but it > might be possible. but even then, it just seems like more complexity and > noise, prolonging the inevitable pain to me. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
