-1 (non-binding) As suggested by Rahul, a breaking change has been introduced (I would call a constant name change a breaking change if I were the release manager). Thanks for Rahul’s finding and Jarek’s suggestion. I tried to create a small PR to mitigate this. I hope it helps. https://github.com/apache/airflow/pull/33148
Best, Wei , > On Aug 5, 2023, at 6:40 PM, Jarek Potiuk <[email protected]> wrote: > > Fix for redis for RC2 merged: https://github.com/apache/airflow/pull/33139 > > On Sat, Aug 5, 2023 at 11:15 AM Jarek Potiuk <[email protected]> wrote: >> >> +1 (binding) - checked signatures, licences, checksums, source code. >> Checked all my changes. I have found an issue with my Redis change I >> made and I am providing a fix for RC2. >> >> (Rahul) -> IMHO it's for discretion of the Release Manager whether >> this is something that should be seen as regression, the Constant >> names are borderline whether they are part of the public API of the >> provider or not. However If I may suggest - the fix to the problem is >> simple - add all old renamed constants to point to the new ones. And >> if you make a PR fixing it now, it might be helping with decision >> making (i.e. fix a problem when you see it, is a good sign that you >> care about it enough to fix it). >> >> J. >> >> On Sat, Aug 5, 2023 at 9:53 AM rahul Vats <[email protected]> wrote: >>> >>> -1 (non-binding) >>> >>> We have tested our example DAGS with the below providers and with >>> *apache-airflow-providers-google==10.6.0rc1 >>> *our Dataproc Example DAGS giving an import error due to this change >>> <https://github.com/apache/airflow/commit/1ea7ae809bf0b8d1c8edf97e4d456b3753a1feca#diff-859a8e37202c3c77bbdd2e6992a3d406c00be015b0b4aef446d24dc2c8a3096cR34> >>> >>> We are Importing *DATAPROC_JOB_LOG_LINK*, however, in the latest release it >>> has been changed to *DATAPROC_JOB_LINK.* >>> >>> 1. apache-airflow-providers-amazon==8.5.0rc1 >>> >>> 2. apache-airflow-providers-apache-hive==6.1.4rc1 >>> >>> 3. apache-airflow-providers-cncf-kubernetes==7.4.rc1 >>> >>> 4. apache-airflow-providers-google==10.6.0rc1 >>> >>> 5. apache-airflow-providers-microsoft-azure==6.2.4rc1 >>> >>> 6. apache-airflow-providers-snowflake==4.4.1rc1 >>> >>> Regards, >>> Rahul Vats >>> 9953794332 >>> >>> >>> On Sat, 5 Aug 2023 at 03:49, Elad Kalif <[email protected]> wrote: >>> >>>> Hey all, >>>> >>>> >>>> I have just cut the new wave Airflow Providers packages. This email is >>>> calling a vote on the release, >>>> >>>> which will last for 72 hours - which means that it will end on August 07, >>>> 2023 22:16 UTC and until 3 binding +1 votes have been received. >>>> >>>> >>>> >>>> Consider this my (binding) +1. >>>> >>>> >>>> Airflow Providers are available at: >>>> >>>> https://dist.apache.org/repos/dist/dev/airflow/providers/ >>>> >>>> >>>> *apache-airflow-providers-<PROVIDER>-*.tar.gz* are the binary >>>> >>>> Python "sdist" release - they are also official "sources" for the provider >>>> packages. >>>> >>>> >>>> *apache_airflow_providers_<PROVIDER>-*.whl are the binary >>>> >>>> Python "wheel" release. >>>> >>>> >>>> The test procedure for PMC members is described in >>>> >>>> >>>> https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#verify-the-release-candidate-by-pmc-members >>>> >>>> >>>> The test procedure for and Contributors who would like to test this RC is >>>> described in: >>>> >>>> >>>> https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#verify-the-release-candidate-by-contributors >>>> >>>> >>>> >>>> Public keys are available at: >>>> >>>> https://dist.apache.org/repos/dist/release/airflow/KEYS >>>> >>>> >>>> Please vote accordingly: >>>> >>>> >>>> [ ] +1 approve >>>> >>>> [ ] +0 no opinion >>>> >>>> [ ] -1 disapprove with the reason >>>> >>>> >>>> >>>> Only votes from PMC members are binding, but members of the community are >>>> >>>> encouraged to test the release and vote with "(non-binding)". >>>> >>>> >>>> Please note that the version number excludes the 'rcX' string. >>>> >>>> This will allow us to rename the artifact without modifying >>>> >>>> the artifact checksums when we actually release. >>>> >>>> >>>> The status of testing the providers by the community is kept here: >>>> >>>> https://github.com/apache/airflow/issues/33132 >>>> >>>> >>>> You can find packages as well as detailed changelog following the below >>>> links: >>>> >>>> >>>> https://pypi.org/project/apache-airflow-providers-amazon/8.5.0rc1/ >>>> https://pypi.org/project/apache-airflow-providers-apache-drill/2.4.3rc1/ >>>> https://pypi.org/project/apache-airflow-providers-apache-hive/6.1.4rc1/ >>>> https://pypi.org/project/apache-airflow-providers-apache-spark/4.1.3rc1/ >>>> https://pypi.org/project/apache-airflow-providers-apache-sqoop/4.0.0rc1/ >>>> https://pypi.org/project/apache-airflow-providers-asana/2.2.2rc1/ >>>> https://pypi.org/project/apache-airflow-providers-celery/3.3.1rc1/ >>>> https://pypi.org/project/apache-airflow-providers-cncf-kubernetes/7.4.1rc1/ >>>> https://pypi.org/project/apache-airflow-providers-common-sql/1.6.2rc1/ >>>> https://pypi.org/project/apache-airflow-providers-docker/3.7.2rc1/ >>>> https://pypi.org/project/apache-airflow-providers-ftp/3.5.0rc1/ >>>> https://pypi.org/project/apache-airflow-providers-google/10.6.0rc1/ >>>> https://pypi.org/project/apache-airflow-providers-imap/3.3.0rc1/ >>>> https://pypi.org/project/apache-airflow-providers-microsoft-azure/6.2.3rc1/ >>>> https://pypi.org/project/apache-airflow-providers-mysql/5.2.1rc1/ >>>> https://pypi.org/project/apache-airflow-providers-openlineage/1.0.1rc1/ >>>> https://pypi.org/project/apache-airflow-providers-redis/3.3.1rc1/ >>>> https://pypi.org/project/apache-airflow-providers-smtp/1.3.0rc1/ >>>> https://pypi.org/project/apache-airflow-providers-snowflake/4.4.1rc1/ >>>> >>>> >>>> Cheers, >>>> >>>> Elad Kalif >>>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] >
