+1 (non-binding). My change works *mostly* as expected, and the unexpected behavior isn't really a problem <https://github.com/apache/airflow/issues/34218#issuecomment-1712578612>
On Mon, Sep 11, 2023 at 1:40 PM Josh Fell <josh.d.f...@astronomer.io.invalid> wrote: > +1 (non-binding) > > Tested my changes (and another related one). Looks good. > > On Mon, Sep 11, 2023 at 2:58 AM Rahul Vats <rah.sharm...@gmail.com> wrote: > > > +1 (non-binding) > > > > Regards, > > Rahul Vats > > 9953794332 > > > > > > On Mon, 11 Sept 2023 at 11:37, Wei Lee <weilee...@gmail.com> wrote: > > > > > +1 (non-binding) > > > > > > 1. Tested with #33825 <https://github.com/apache/airflow/pull/33825>, > > > #33822 <https://github.com/apache/airflow/pull/33822>, #34098 < > > > https://github.com/apache/airflow/pull/34098> > > > 2. astronomer-providers example DAGs ran fine, as Pankaj mentioned. > > > > > > It would be nice if we could include these documentation changes as > well > > > #34104 <https://github.com/apache/airflow/pull/34104>, #34103 < > > > https://github.com/apache/airflow/pull/34103>, #34102 < > > > https://github.com/apache/airflow/pull/34102>, #34101 < > > > https://github.com/apache/airflow/pull/34101>, #34097 < > > > https://github.com/apache/airflow/pull/34097>, #34096 < > > > https://github.com/apache/airflow/pull/34096>, #34095 < > > > https://github.com/apache/airflow/pull/34095>, #34094 < > > > https://github.com/apache/airflow/pull/34094>, #34074 < > > > https://github.com/apache/airflow/pull/34074>, #34073 < > > > https://github.com/apache/airflow/pull/34073>? > > > Thanks! > > > > > > Best, > > > Wei > > > > > > > On Sep 11, 2023, at 12:48 PM, Jarek Potiuk <ja...@potiuk.com> wrote: > > > > > > > > +1 (binding) - checked my changes, signatures, licences, checksums, > > > > verified sources are the same in packages as in tags. > > > > > > > > On Mon, Sep 11, 2023 at 5:35 AM Phani Kumar > > > > <phani.ku...@astronomer.io.invalid> wrote: > > > > > > > >> +1 non binding > > > >> > > > >> On Mon, 11 Sept 2023, 01:39 Pankaj Koti, <pankaj.k...@astronomer.io > > > >> .invalid> > > > >> wrote: > > > >> > > > >>> +1 (non-binding) > > > >>> > > > >>> 1. Tested my set of changes in PR #34018. > > > >>> 2. astronomer-providers DAGs ran fine for below list of RCs: > > > >>> apache-airflow-providers-amazon==8.7.0rc1 > > > >>> apache-airflow-providers-apache-hive==6.1.6rc1 > > > >>> apache-airflow-providers-apache-livy==3.5.4rc1 > > > >>> apache-airflow-providers-cncf-kubernetes==7.5.1rc1 > > > >>> apache-airflow-providers-databricks==4.5.0rc1 > > > >>> apache-airflow-providers-dbt-cloud==3.3.0rc1 > > > >>> apache-airflow-providers-google==10.8.0rc1 > > > >>> apache-airflow-providers-http==4.5.2rc1 > > > >>> apache-airflow-providers-microsoft-azure==7.0.0rc1 > > > >>> apache-airflow-providers-sftp==4.6.1rc1 > > > >>> apache-airflow-providers-snowflake==5.0.1rc1 > > > >>> 3. There is a discussion on PR > > > >>> https://github.com/apache/airflow/pull/34257 > > > >>> WRT to Google provider RC's dependency on common-sql. > > > >>> And I am okay with the release manager's decision on it. > > > >>> > > > >>> > > > >>> Regards, > > > >>> > > > >>> > > > >>> > > > >>> Pankaj Koti > > > >>> > > > >>> *Senior Software Engineer, *OSS Engineering Team. > > > >>> Location: Pune, India > > > >>> > > > >>> Timezone: Indian Standard Time (IST) > > > >>> > > > >>> Email: pankaj.k...@astronomer.io > > > >>> > > > >>> Mobile: +91 9730079985 > > > >>> > > > >>> > > > >>> On Sun, Sep 10, 2023 at 8:02 PM Pankaj Koti < > > pankaj.k...@astronomer.io > > > > > > > >>> wrote: > > > >>> > > > >>>> Hi, > > > >>>> > > > >>>> Tested my change #34018 < > > https://github.com/apache/airflow/pull/34018 > > > > > > > >>> in > > > >>>> the Google RC 10.8.0rc1. It works fine, > > > >>>> but it also has a dependency on common-sql provider 1.7.2.rc1 for > > > >>>> the change in the same PR. If the common-sql provider is not > updated > > > >>>> then it fails. How do we handle cross-provider dependency bumps > > > >>>> during releases? Does it get handled automatically or do we need a > > > >>>> manual minimum version dependency bump here in Google RC to > contain > > > >>>> common-sql>=1.7.2? > > > >>>> > > > >>>> Regards, > > > >>>> > > > >>>> > > > >>>> > > > >>>> Pankaj Koti > > > >>>> > > > >>>> *Senior Software Engineer, *OSS Engineering Team. > > > >>>> Location: Pune, India > > > >>>> > > > >>>> Timezone: Indian Standard Time (IST) > > > >>>> > > > >>>> Email: pankaj.k...@astronomer.io > > > >>>> > > > >>>> Mobile: +91 9730079985 > > > >>>> > > > >>>> > > > >>>> On Sun, Sep 10, 2023 at 9:51 AM Amogh Desai < > > amoghdesai....@gmail.com > > > > > > > >>>> wrote: > > > >>>> > > > >>>>> I didn't have many changes this time but I tested out by running > a > > > few > > > >>>>> dags, mostly on cncf provider and they work as expected. > > > >>>>> > > > >>>>> +1 non binding > > > >>>>> > > > >>>>> Thanks, > > > >>>>> Amogh Desai > > > >>>>> > > > >>>>> On Sun, Sep 10, 2023, 03:41 Hussein Awala <huss...@awala.fr> > > wrote: > > > >>>>> > > > >>>>>> I checked the signatures, the checksums, the licences and the > > source > > > >>>>> code. > > > >>>>>> I checked my changes, they are all present in the RC. I ran some > > > >>> testing > > > >>>>>> dags for AWS and Kubernetes providers, all seem good. > > > >>>>>> > > > >>>>>> It seems like there is an issue with dbt.cloud provider ( > > > >>>>>> > > > >>> > > https://github.com/apache/airflow/issues/34218#issuecomment-1712251647 > > > >>>>> ), > > > >>>>>> but I'm not sure if there is an option to deactivate the > > openLineage > > > >>>>> for a > > > >>>>>> specific operator, therefore deactivating the new feature > without > > > >>>>> affecting > > > >>>>>> the other providers. > > > >>>>>> > > > >>>>>> 0 (binding) for dbt.cloud provider > > > >>>>>> +1 (binding) for other providers > > > >>>>>> > > > >>>>>> On Fri, Sep 8, 2023 at 5:56 PM Elad Kalif <elad...@apache.org> > > > >> wrote: > > > >>>>>> > > > >>>>>>> Hey all, > > > >>>>>>> > > > >>>>>>> I have just cut the new wave Airflow Providers packages. This > > > >> email > > > >>> is > > > >>>>>>> calling a vote on the release, > > > >>>>>>> which will last for 72 hours - which means that it will end on > > > >>>>> September > > > >>>>>>> 11, 2023 15:53 PM UTC and until 3 binding +1 votes have been > > > >>> received. > > > >>>>>>> > > > >>>>>>> Consider this my (binding) +1. > > > >>>>>>> > > > >>>>>>> Airflow Providers are available at: > > > >>>>>>> https://dist.apache.org/repos/dist/dev/airflow/providers/ > > > >>>>>>> > > > >>>>>>> *apache-airflow-providers-<PROVIDER>-*.tar.gz* are the binary > > > >>>>>>> Python "sdist" release - they are also official "sources" for > the > > > >>>>>> provider > > > >>>>>>> packages. > > > >>>>>>> > > > >>>>>>> *apache_airflow_providers_<PROVIDER>-*.whl are the binary > > > >>>>>>> Python "wheel" release. > > > >>>>>>> > > > >>>>>>> The test procedure for PMC members is described in > > > >>>>>>> > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>> > > > >> > > > > > > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#verify-the-release-candidate-by-pmc-members > > > >>>>>>> > > > >>>>>>> The test procedure for and Contributors who would like to test > > > >> this > > > >>>>> RC is > > > >>>>>>> described in: > > > >>>>>>> > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>> > > > >> > > > > > > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_PROVIDER_PACKAGES.md#verify-the-release-candidate-by-contributors > > > >>>>>>> > > > >>>>>>> Public keys are available at: > > > >>>>>>> https://dist.apache.org/repos/dist/release/airflow/KEYS > > > >>>>>>> > > > >>>>>>> Please vote accordingly: > > > >>>>>>> > > > >>>>>>> [ ] +1 approve > > > >>>>>>> [ ] +0 no opinion > > > >>>>>>> [ ] -1 disapprove with the reason > > > >>>>>>> > > > >>>>>>> Only votes from PMC members are binding, but members of the > > > >>> community > > > >>>>> are > > > >>>>>>> encouraged to test the release and vote with "(non-binding)". > > > >>>>>>> > > > >>>>>>> Please note that the version number excludes the 'rcX' string. > > > >>>>>>> This will allow us to rename the artifact without modifying > > > >>>>>>> the artifact checksums when we actually release. > > > >>>>>>> > > > >>>>>>> The status of testing the providers by the community is kept > > here: > > > >>>>>>> https://github.com/apache/airflow/issues/34218 > > > >>>>>>> > > > >>>>>>> You can find packages as well as detailed changelog following > the > > > >>>>> below > > > >>>>>>> links: > > > >>>>>>> > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-airbyte/3.3.2rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-alibaba/2.5.3rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-amazon/8.7.0rc1/ > > > >>>>>>> > > > >>>>> > > > >> > > https://pypi.org/project/apache-airflow-providers-apache-beam/5.2.3rc1/ > > > >>>>>>> > > > >>>>> > > > >>> > > > > https://pypi.org/project/apache-airflow-providers-apache-drill/2.4.4rc1/ > > > >>>>>>> > > > >>>>> > > > >>> > > > > https://pypi.org/project/apache-airflow-providers-apache-flink/1.1.3rc1/ > > > >>>>>>> > > > >>>>> > > > >> > > https://pypi.org/project/apache-airflow-providers-apache-hdfs/4.1.1rc1/ > > > >>>>>>> > > > >>>>> > > > >> > > https://pypi.org/project/apache-airflow-providers-apache-hive/6.1.6rc1/ > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>> > > > >> > > > > > > https://pypi.org/project/apache-airflow-providers-apache-impala/1.1.3rc1/ > > > >>>>>>> > > > >>>>> > > > >> > > https://pypi.org/project/apache-airflow-providers-apache-livy/3.5.4rc1/ > > > >>>>>>> > > > >>>>> > > > >> > > https://pypi.org/project/apache-airflow-providers-apache-pig/4.1.2rc1/ > > > >>>>>>> > > > >>>>> > > > >>> > > > > https://pypi.org/project/apache-airflow-providers-apache-pinot/4.1.4rc1/ > > > >>>>>>> > > > >>>>> > > > >>> > > > > https://pypi.org/project/apache-airflow-providers-apache-spark/4.1.5rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-apprise/1.0.2rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-celery/3.3.4rc1/ > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>> > > > >> > > > > > > https://pypi.org/project/apache-airflow-providers-cncf-kubernetes/7.5.1rc1/ > > > >>>>>>> > > > >>>>> > > > >> > > https://pypi.org/project/apache-airflow-providers-common-sql/1.7.2rc1/ > > > >>>>>>> > > > >>>>> > > > >> > > https://pypi.org/project/apache-airflow-providers-databricks/4.5.0rc1/ > > > >>>>>>> > > > >>> > > https://pypi.org/project/apache-airflow-providers-dbt-cloud/3.3.0rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-discord/3.3.1rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-docker/3.7.5rc1/ > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>> > > > >> > > > > > > https://pypi.org/project/apache-airflow-providers-elasticsearch/5.0.2rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-exasol/4.2.5rc1/ > > > >>>>>>> > > > >>> > https://pypi.org/project/apache-airflow-providers-facebook/3.2.2rc1/ > > > >>>>>>> > https://pypi.org/project/apache-airflow-providers-ftp/3.5.2rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-google/10.8.0rc1/ > > > >>>>>>> > > > >>> > > https://pypi.org/project/apache-airflow-providers-hashicorp/3.4.3rc1/ > > > >>>>>>> > https://pypi.org/project/apache-airflow-providers-http/4.5.2rc1/ > > > >>>>>>> > https://pypi.org/project/apache-airflow-providers-imap/3.3.2rc1/ > > > >>>>>>> > > > >>> > https://pypi.org/project/apache-airflow-providers-influxdb/2.2.3rc1/ > > > >>>>>>> > https://pypi.org/project/apache-airflow-providers-jdbc/4.0.2rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-jenkins/3.3.2rc1/ > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>> > > > >> > > > > > > https://pypi.org/project/apache-airflow-providers-microsoft-azure/7.0.0rc1/ > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>> > > > >> > > > > > > https://pypi.org/project/apache-airflow-providers-microsoft-psrp/2.3.2rc1/ > > > >>>>>>> > > https://pypi.org/project/apache-airflow-providers-mongo/3.2.2rc1/ > > > >>>>>>> > > https://pypi.org/project/apache-airflow-providers-mysql/5.3.1rc1/ > > > >>>>>>> > > https://pypi.org/project/apache-airflow-providers-neo4j/3.3.3rc1/ > > > >>>>>>> > > > >>>>> > > > >> > > https://pypi.org/project/apache-airflow-providers-openlineage/1.1.0rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-oracle/3.7.4rc1/ > > > >>>>>>> > > > >>> > > https://pypi.org/project/apache-airflow-providers-pagerduty/3.3.1rc1/ > > > >>>>>>> > > > >>> > https://pypi.org/project/apache-airflow-providers-postgres/5.6.1rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-presto/5.1.4rc1/ > > > >>>>>>> > > https://pypi.org/project/apache-airflow-providers-redis/3.3.2rc1/ > > > >>>>>>> > > > >>>>> > > > >> > > https://pypi.org/project/apache-airflow-providers-salesforce/5.4.3rc1/ > > > >>>>>>> > > https://pypi.org/project/apache-airflow-providers-samba/4.2.2rc1/ > > > >>>>>>> > https://pypi.org/project/apache-airflow-providers-sftp/4.6.1rc1/ > > > >>>>>>> > > https://pypi.org/project/apache-airflow-providers-slack/8.1.0rc1/ > > > >>>>>>> > https://pypi.org/project/apache-airflow-providers-smtp/1.3.2rc1/ > > > >>>>>>> > > > >>> > > https://pypi.org/project/apache-airflow-providers-snowflake/5.0.1rc1/ > > > >>>>>>> > https://pypi.org/project/apache-airflow-providers-ssh/3.7.3rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-tableau/4.2.2rc1/ > > > >>>>>>> > > https://pypi.org/project/apache-airflow-providers-trino/5.3.1rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-vertica/3.5.2rc1/ > > > >>>>>>> > > > >> https://pypi.org/project/apache-airflow-providers-zendesk/4.3.2rc1/ > > > >>>>>>> > > > >>>>>>> Cheers, > > > >>>>>>> Elad Kalif > > > >>>>>>> > > > >>>>>> > > > >>>>> > > > >>>> > > > >>> > > > >> > > > > > > > > >
