+1 non binding. I check my change and it works as expected. I also ran few testing DAGs and they ran fine.
On 2024/03/08 00:14:12 Jarek Potiuk wrote: > +1 (binding): checked reproducibility, sources, licences, checksums, > run a few dags, tested all my changes, all looks good. > > One caveat. I think we still have the change that makes the default > image `airflow/2.8.3rc1` point to `airflow/2.8.3rc1-python3.11` > instead of `airfllow/2.8.3rc1-python3.8`. This is an aftermath of > moving the "default image" change to 2.9.* line after we found out the > bug in 2.8.0 that prevented the change from going live in 2.8 (but > then the fix crept-in the 2.8 branch) > > Similarly as for 2.8.2 last week - I fixed it manually by `docker > login` followed by: > > regctl image copy --force-recursive --digest-tags > apache/airflow:2.8.3rc1-python3.8 apache/airflow:2.8.3rc1 > regctl image copy --force-recursive --digest-tags > apache/airflow:slim-2.8.3rc1-python3.8 apache/airflow:slim-2.8.3rc1 > > I think it's not worth cancelling the release and fixing it in the > code, we can "fix" the final images in the same way after they are > pushed. It takes literally a few seconds, we just have to remember to > do it before the announcement. > > J. > > On Thu, Mar 7, 2024 at 11:13 PM Ephraim Anierobi > <ephraimanier...@apache.org> wrote: > > > > Hey fellow Airflowers, > > > > I have cut Airflow 2.8.3rc1. This email is calling a vote on the release, > > which will last at least 72 hours, from Thursday, March 7, 2024 at 10:10 pm > > UTC > > until Sunday, March 10, 2024, at 10:10 pm UTC > > <https://www.timeanddate.com/worldclock/fixedtime.html?msg=8&iso=20240310T2210&p1=1440>, > > and until 3 binding +1 votes have been received. > > > > > > The status of testing of the release is kept at > > https://github.com/apache/airflow/issues/37982 > > > > Consider this my (binding) +1. > > > > Airflow 2.8.3rc1 is available at: > > https://dist.apache.org/repos/dist/dev/airflow/2.8.3rc1/ > > > > *apache-airflow-2.8.3-source.tar.gz* is a source release that comes with > > INSTALL instructions. > > *apache-airflow-2.8.3.tar.gz* is the binary Python "sdist" release. > > *apache_airflow-2.8.3-py3-none-any.whl* is the binary Python wheel "binary" > > release. > > > > Public keys are available at: > > https://dist.apache.org/repos/dist/release/airflow/KEYS > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Only votes from PMC members are binding, but all members of the community > > are encouraged to test the release and vote with "(non-binding)". > > > > The test procedure for PMC members is described in: > > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md\#verify-the-release-candidate-by-pmc-members > > > > The test procedure for and Contributors who would like to test this RC is > > described in: > > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md\#verify-the-release-candidate-by-contributors > > > > > > Please note that the version number excludes the `rcX` string, so it's now > > simply 2.8.3. This will allow us to rename the artifact without modifying > > the artifact checksums when we actually release. > > > > Release Notes: > > https://github.com/apache/airflow/blob/2.8.3rc1/RELEASE_NOTES.rst > > > > For information on what goes into a release please see: > > https://github.com/apache/airflow/blob/main/dev/WHAT_GOES_INTO_THE_NEXT_RELEASE.md > > > > Changes since 2.8.2: > > > > *Significant Changes* > > > > The smtp provider is now pre-installed when you install Airflow. (#37713) > > > > *Bug Fixes* > > - Add "MENU" permission in auth manager (#37881) > > - Fix external_executor_id being overwritten (#37784) > > - Make more MappedOperator members modifiable (#37828) > > - Set parsing context dag_id in dag test command (#37606) > > > > *Miscellaneous* > > - Remove useless methods from security manager (#37889) > > - Improve code coverage for TriggerRuleDep (#37680) > > - The SMTP provider is now preinstalled when installing Airflow (#37713) > > - Bump min versions of openapi validators (#37691) > > - Properly include ``airflow_pre_installed_providers.txt`` artifact (#37679) > > > > *Doc Only Changes* > > - Clarify lack of sync between workers and scheduler (#37913) > > - Simplify some docs around airflow_local_settings (#37835) > > - Add section about local settings configuration (#37829) > > - Fix docs of ``BranchDayOfWeekOperator`` (#37813) > > - Write to secrets store is not supported by design (#37814) > > - ``ERD`` generating doc improvement (#37808) > > - Update incorrect config value (#37706) > > - Update security model to clarify Connection Editing user's capabilities > > (#37688) > > - Fix ImportError on examples dags (#37571) > > > > Cheers, > > Ephraim > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > For additional commands, e-mail: dev-h...@airflow.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org For additional commands, e-mail: dev-h...@airflow.apache.org
