+1 non binding, tested my changes on a few dag examples, everything looks good!
Regards, Pavan Kumar On Sat, Oct 12, 2024 at 4:43 AM Kaxil Naik <kaxiln...@gmail.com> wrote: > +1 binding on sigs, license & checksums > > On Fri, 11 Oct 2024 at 20:46, Jarek Potiuk <ja...@potiuk.com> wrote: > > > +1 (binding) - checked reproducibility, checksums, signatures, licences. > > That also includes sdist packages tests. > > > > I also used the opportunity to improve our release manager and PMC steps > > for reproducibility of providers to more selectively exclude Python 3.12 > > when running reproducibility checks: > > https://github.com/apache/airflow/pull/42944 > > > > There was a problem raised that Python 3.12 could not be used for breeze > > (there was a python version check), and the main reason was that > > reproducibility check also includes verification of .sdist packages of > ours > > - and this verification fails for Python 3.12 because Apache Beam still > > does not support Python 3.12 ( > https://github.com/apache/beam/issues/32617 > > ) > > > > Apparently it was not very clear why Python 3.12 is excluded from breeze, > > so I am adding this explanation here for those PMC members who follow the > > most important "release" threads of ours, so that they are aware of it. > > > > Those PMC members who do not run PMC verification now should be able to > use > > Python 3.12 to help release manager to verify if providers are ready to > > release and gives they +1 > > > > Those PMC members who do not help in this effort, can still use Python > 3.12 > > for their breeze commands. > > > > I hope that explanation is prominent enough so that I do not have to > > explain it additionally, > > > > J. > > >
