HsiuChuanHsu opened a new pull request, #55355:
URL: https://github.com/apache/airflow/pull/55355
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
## Description
This PR fixes a issue where `KubernetesJobOperator` was completely ignoring
the `on_finish_action` parameter despite inheriting it from
KubernetesPodOperator.
> **Problem**: This resulted in pods never being cleaned up regardless of
the configured action.
## Solution
**Core Logic for Job and Pod Cleanup**
- **Job Deletion**:
If the cleanup action requires deletion (`DELETE_POD` or
`DELETE_SUCCEEDED_POD` for successful jobs), the entire Job is deleted.
- Uses `propagation_policy="Foreground"` to ensure associated Pods are
also deleted via cascading deletion.
- **Pod Cleanup**:
If the Job is not deleted, terate through each Pod and execute the inherited
`cleanup()` method for individual Pod processing.
- Handle Pod-level cleanup when the Job is not deleted.
- Decide whether to delete Pods based on `on_finish_action`.
https://github.com/apache/airflow/blob/69bdd6bc04db34f764f64c34b7d1cd79cc372e2b/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py#L1017-L1023
- **OnFinishAction Classifications**
The `OnFinishAction` enum defines the possible actions to take when a Pod or
Job completes:
- `DELETE_POD`: Always deletes both job and associated pods
- `DELETE_SUCCEEDED_POD`: Only deletes job and pods if the job succeeded
- `KEEP_POD`: Never deletes the job, but calls cleanup() for pod management
https://github.com/apache/airflow/blob/69bdd6bc04db34f764f64c34b7d1cd79cc372e2b/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py#L1019-L1024
Fixes: #55192
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
