yangyulely opened a new pull request, #55492:
URL: https://github.com/apache/airflow/pull/55492
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
closes: #53961
related: #53961
## Problem Analysis
The issue was that when editing non-string fields (like lists, booleans,
etc.) through the "Extra fields" in the Connection Form (not using the JSON
editor), the fields were being converted to strings instead of maintaining
their original data types.
## Root Cause
The problem was in the `FieldSelector.tsx` component. The `inferType`
function was only using the `initialParamDict` (which contains schema
definitions) to determine field types, but it wasn't considering the actual
current values stored in `paramsDict` when editing existing connections.
## Solution Implemented
I modified the `FieldSelector` component in
`airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldSelector.tsx` to:
1. __Use both parameter dictionaries__: The component now accesses both
`initialParamDict` (for schema information) and `paramsDict` (for current
values) from the `useParamStore`.
2. __Combine schema with actual values__: Created a combined parameter
object that uses:
- Schema information from `initialParamDict`
- Actual current values from `paramsDict`
3. __Preserve original data types__: This ensures that when editing existing
extra fields, the type inference is based on the actual stored values rather
than just the schema defaults, preventing arrays, booleans, numbers, and
objects from being converted to strings.
## Improvement
### Extra Fields JSON
```json
{
"string": "hello world",
"list": [
"p1",
"p2",
"p3",
"p4"
],
"bool": true,
"num": 1234,
"object": {
"key": "value"
}
}
```
| Before | After |
|:----:|:----:|
| <img width="640" alt="before_fix"
src="https://github.com/user-attachments/assets/e19e7988-9e42-4f5c-add0-9e79825a3d59";
/> | <img width="640" alt="fix_extra_fields"
src="https://github.com/user-attachments/assets/1e5a0520-595d-4a86-9982-baa2929d351f";
/> |
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #53961
related: #53961
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
