vincbeck commented on code in PR #55469:
URL: https://github.com/apache/airflow/pull/55469#discussion_r2340770098
##########
airflow-core/src/airflow/executors/executor_loader.py:
##########
@@ -41,11 +42,11 @@
# Used to lookup an ExecutorName via a string alias or module path. An
# executor may have both so we need two lookup dicts.
-_alias_to_executors: dict[str, ExecutorName] = {}
-_module_to_executors: dict[str, ExecutorName] = {}
+_alias_to_executors: dict[str | None, dict[str, ExecutorName]] =
defaultdict(dict)
Review Comment:
nit, rename these to append `_per_team`? e.g. `_alias_to_executors_per_team`?
##########
airflow-core/src/airflow/executors/executor_loader.py:
##########
@@ -230,17 +245,17 @@ def init_executors(cls) -> list[BaseExecutor]:
return loaded_executors
@classmethod
- def lookup_executor_name_by_str(cls, executor_name_str: str) ->
ExecutorName:
+ def lookup_executor_name_by_str(cls, executor_name_str: str,
team_name=None) -> ExecutorName:
Review Comment:
```suggestion
def lookup_executor_name_by_str(cls, executor_name_str: str, team_name:
str | None = None) -> ExecutorName:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
