ashb commented on issue #54143: URL: https://github.com/apache/airflow/issues/54143#issuecomment-3274485272
> Does using Log.extra for this purpose sound reasonable? Probably -- though I guess the main question is how and where does this show up in the API/UI? Does it show up for previous TI attempts too (i.e. for rows in the TIHistory table) > If so, what would be the best place in the code to insert this Log row so it is written once per task attempt, by the actual worker? (e.g. in the Celery worker task wrapper, in StandardTaskRunner, or somewhere else?). Here https://github.com/apache/airflow/blob/65e6a1ed0cb257a936e906623d6ea7b535a11f40/airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py#L199 -- this is the point where we know the task is started, and that will work for all executors. You'll also need to change the request that the TaskSDK sends, and due to the version constraints we have, this will have to be done in an API compatible way - see https://github.com/apache/airflow/blob/65e6a1ed0cb257a936e906623d6ea7b535a11f40/contributing-docs/19_execution_api_versioning.rst#L21 (I.e. for requests from older TaskSDK versions, we'll just put the one existing hostname into both places) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
