Common SQL provider will need it for sure as it is also not declared there.

-----Original Message-----
From: Jarek Potiuk <[email protected]> 
Sent: 30 December 2025 10:35
To: [email protected]
Subject: Re: [HELP NEEDED] Adding SqlAlchemy dependencies in providers

EXTERNAL MAIL: Indien je de afzender van deze e-mail niet kent en deze niet 
vertrouwt, klik niet op een link of open geen bijlages. Bij twijfel, stuur deze 
e-mail als bijlage naar [email protected]<mailto:[email protected]>.

Yeah. This is why we need to do it one-by-one and make individual decisions on 
how to approach this :). Nice thing is that once we complete task isolation and 
task-sdk will not have sqlalchemy dependencies, the way how we do testing with 
uv sync will catch those kind of errors automatically - because sqlalchemy will 
not be installed during tests if not declared - so it means that we do not have 
to even have any prek hooks to check future changes.

On Tue, Dec 30, 2025 at 7:02 AM Amogh Desai <[email protected]> wrote:

> Good catch!
>
> Strange to see that some of those providers need sqla for some feature 
> of their own!
>
> Thanks & Regards,
> Amogh Desai
>
>
> On Tue, Dec 30, 2025 at 1:19 AM Jarek Potiuk <[email protected]> wrote:
>
> > While reviewing a hive PR I realized that some of our providers have 
> > an implicit sqlalchemy dependency - I think all those providers do 
> > not have sqlalchemy declared as one because currently sqlalchemy is 
> > provided by "airflow-core" - but when we complete task isolation, 
> > task-sdk will not have sqlalchemy as dependency, so those providers 
> > should have it
> declared -
> > most of them as optional "extra" dependency, some of them as "required"
> > (for the common.sql and related, sqlalchemy should be purely optional).
> >
> > I created issue 
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
> > thub.com%2Fapache%2Fairflow%2Fissues%2F59895&data=05%7C02%7Cdavid.bl
> > ain%40infrabel.be%7C4a3f5bea30ae4957673608de4786c035%7Cb82bc314ab8e4
> > d6fb18946f02e1f27f2%7C0%7C0%7C639026841233403568%7CUnknown%7CTWFpbGZ
> > sb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkF
> > OIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=bqFVuOi%2BwMxuQXibP
> > qosYLBdSfoMXYvQEC0%2BlnjPm6k%3D&reserved=0 -> as
> "good
> > first issue" and created sub-issues for each provider that uses
> sqlalchemy
> > now.
> >
> > Feel free to grab them.
> >
> > J.
> >
>

Reply via email to