Could someone look into merging this? https://github.com/apache/incubator-airflow/pull/2489
I've been actively maintaining it conflict free for some months. Thanks! Cheers, Diogo On 4 August 2017 at 15:50, Diogo Franco <diogoalexfra...@gmail.com> wrote: > A PR implementing this is here https://github.com/ > apache/incubator-airflow/pull/2489 > > Cheers, > Diogo > > On 30 July 2017 at 14:29, Diogo Franco <diogoalexfra...@gmail.com> wrote: > >> Hi Maxime, >> >> Awesome, I also believe PythonSensor makes sense in the core package of >> course. These also allow someone trying out airflow to easily build dag's >> with sensors without setting up connections, for example. >> >> I'll open a different ticket for PythonSensor and do it separately, if >> that is ok. >> >> Cheers. >> >> On 28 July 2017 at 17:46, Maxime Beauchemin <maximebeauche...@gmail.com> >> wrote: >> >>> BashSensor would be a good contribution. >>> >>> I'm guessing that the reason why it doesn't exist or (PythonSensor >>> doesn't >>> exist for that matter) is that it's pretty easy to derive >>> BaseSensorOperator and make your own. It still would be neat to have it >>> in >>> the core package and in the docs. >>> >>> Max >>> >>> On Fri, Jul 28, 2017 at 7:12 AM, Diogo Franco <diogoalexfra...@gmail.com >>> > >>> wrote: >>> >>> > Hi, >>> > >>> > I was looking for a sensor that allowed me to customize the sensing >>> logic. >>> > I couldn't find any way of doing this and wrote a BashSensor, which >>> returns >>> > True or False based on a command/script's return code. The >>> implementation >>> > is similar to the BashOperator, and it seems to me that it would fit >>> pretty >>> > naturally within airflow. >>> > >>> > Is there another way to achieve this that I don't know about? If you >>> think >>> > it is worthwhile, I'm happy to work on some tests and a PR. >>> > >>> > Thank you! >>> > >>> >> >> >
