- **status**: review --> in-progress - **Reviewer**: Dave Brondsema - **Comment**:
Looks pretty good, but found 2 minor issues: * on the front page of a tracker, the preference isn't used, it still uses 25 for the size. E.g. /p/project1/test-tracker/ in SourceForge's default dataset. * If a user doesn't have a preference set, /auth/preferences shows "25" since that's the first item in the drop-down. But `handle_paging` has `default=50`, so practically the default default is 50 in most places. --- ** [tickets:#7794] "Page Size" preference must actually affect pagination** **Status:** in-progress **Milestone:** unreleased **Labels:** 42cc sf-1 sf-current **Created:** Mon Nov 03, 2014 12:36 PM UTC by Igor Bondarenko **Last Updated:** Fri Nov 14, 2014 11:57 AM UTC **Owner:** Igor Bondarenko >From https://sourceforge.net/p/allura/tickets/7716/ > Changing "Page Size" on /auth/preferences doesn't do anything. > > There are a lot of places where page size set manually to some value. E.g. > ticket controller sets it to 10, wiki's and discussion to 25, probably > there's more places like that. > > There are also two helpers used throughout code for pagination > `g.handle_paging` and `h.paging_sanitizer`. While former is using page size > preference, the latter is not. > > Other than that `g.handle_paging` uses some strange (to me) logic. It sets > your page size preference to the particular value, if limit is provided (e.g. > by manually appending `?limit=N` to url, or when hard limit is provided > inside the controller). Thus page size is reset in very obscure (to the user) > way. > > Most obvious and easy to use way would be to always use page size from user > preferences for all pages (if it is not overridden by controller for some > reason) and avoid resetting this setting as described above. - Comments everywhere must use "Page Size" value from user preferences (if is not overridden by `?limit=N` url param - Probably merge `h.paging_sanitizer` & `g.handle_paging` into one to avoid future confusions --- Sent from forge-allura.apache.org because [email protected] is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
