---
** [tickets:#7794] "Page Size" preference must actually affect pagination**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc
**Created:** Mon Nov 03, 2014 12:36 PM UTC by Igor Bondarenko
**Last Updated:** Mon Nov 03, 2014 12:36 PM UTC
**Owner:** Igor Bondarenko
>From https://sourceforge.net/p/allura/tickets/7716/
> Changing "Page Size" on /auth/preferences doesn't do anything.
>
> There are a lot of places where page size set manually to some value. E.g.
> ticket controller sets it to 10, wiki's and discussion to 25, probably
> there's more places like that.
>
> There are also two helpers used throughout code for pagination
> `g.handle_paging` and `h.paging_sanitizer`. While former is using page size
> preference, the latter is not.
>
> Other than that `g.handle_paging` uses some strange (to me) logic. It sets
> your page size preference to the particular value, if limit is provided (e.g.
> by manually appending `?limit=N` to url, or when hard limit is provided
> inside the controller). Thus page size is reset in very obscure (to the user)
> way.
>
> Most obvious and easy to use way would be to always use page size from user
> preferences for all pages (if it is not overridden by controller for some
> reason) and avoid resetting this setting as described above.
- Comments everywhere must use "Page Size" value from user preferences (if is
not overridden by `?limit=N` url param
- Probably merge `h.paging_sanitizer` & `g.handle_paging` into one to avoid
future confusions
---
Sent from forge-allura.apache.org because [email protected] is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
