eyalbenivri commented on a change in pull request #20: PySpark fixes for YARN
and Mesos
URL: https://github.com/apache/incubator-amaterasu/pull/20#discussion_r191042874
##########
File path:
executor/src/main/scala/org/apache/amaterasu/executor/execution/actions/runners/spark/PySpark/PySparkRunner.scala
##########
@@ -16,8 +16,9 @@
*/
package org.apache.amaterasu.executor.execution.actions.runners.spark.PySpark
-import java.io.{File, PrintWriter, StringWriter}
+import java.io._
Review comment:
As a convention, it is recommended to avoid import entire libraries (as in
python it is kind of a code-smell to do 'from foo import *'. Please specify
specific classes/objects etc to import.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
