eyalbenivri commented on a change in pull request #20: PySpark fixes for YARN and Mesos URL: https://github.com/apache/incubator-amaterasu/pull/20#discussion_r191042876
########## File path: executor/src/main/scala/org/apache/amaterasu/executor/execution/actions/runners/spark/PySpark/PySparkRunner.scala ########## @@ -28,7 +29,7 @@ import org.apache.amaterasu.sdk.AmaterasuRunner import org.apache.spark.SparkEnv import org.apache.spark.sql.SparkSession -import scala.sys.process.Process +import scala.sys.process._ Review comment: As a convention, it is recommended to avoid import entire libraries (as in python it is kind of a code-smell to do 'from foo import *'. Please specify specific classes/objects etc to import. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services