nadav-har-tzvi commented on a change in pull request #42: Amaterasu 8 URL: https://github.com/apache/incubator-amaterasu/pull/42#discussion_r257777039
########## File path: frameworks/spark/dispatcher/src/main/scala/org/apache/amaterasu/frameworks/spark/dispatcher/SparkSetupProvider.scala ########## @@ -67,7 +67,7 @@ class SparkSetupProvider extends FrameworkSetupProvider { override def getEnvironmentVariables: util.Map[String, String] = conf.mode match { - case "mesos" => Map[String, String](s"SPARK_HOME" -> s"spark-${conf.Webserver.sparkVersion}") + case "mesos" => Map[String, String]("SPARK_HOME" ->"spark-2.2.1-bin-hadoop2.7","SPARK_HOME_DOCKER" -> "/opt/spark/") Review comment: Is this a mistake? What happens if I want to supply a different spark version? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services