nadav-har-tzvi commented on a change in pull request #42: Amaterasu 8
URL: https://github.com/apache/incubator-amaterasu/pull/42#discussion_r257834629
##########
File path:
leader/src/main/scala/org/apache/amaterasu/leader/yarn/ApplicationMaster.scala
##########
@@ -205,20 +206,20 @@ class ApplicationMaster extends Logging with
AMRMClientAsync.CallbackHandler {
registrationResponse
}
- private def setupMessaging(jobId: String): Unit = {
-
- val cf = new ActiveMQConnectionFactory(address)
- val conn = cf.createConnection()
- conn.start()
-
- val session = conn.createSession(false, Session.AUTO_ACKNOWLEDGE)
- //TODO: move to a const in common
- val destination = session.createTopic("JOB.REPORT")
-
- val consumer = session.createConsumer(destination)
- consumer.setMessageListener(new ActiveReportListener)
-
- }
+// private def setupMessaging(jobId: String): Unit = {
Review comment:
Is this piece of commented code needed or can it simply be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
