[
https://issues.apache.org/jira/browse/AMBARI-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864497#comment-13864497
]
Sumit Mohanty commented on AMBARI-4150:
---------------------------------------
Overall looks good. Few comments and questions ...
{quote}
if (!isSchedulerAvailable()) {
throw new AmbariException("Scheduler unavailable.");
}
{quote}
The above check is there in few places. The check itself is good but what are
the condition for scheduler not being available. If it is not available then
can one still submit requests the do not have a schedule.
*
ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
** If any exception is thrown in the method (scheduleBatch) then how does
RequestExecution recover? As I understand, triggers are created when jobs are
persisted and when ambari-server starts. So if an error is encountered while
triggering a job then does it mean that till ambari-server restarted no new
jobs for that RequestExecution will not be created
** Is there a validation somewhere to ensure that batch orderIds are unique
within the batch?
** synchronized Long executeBatchRequest() - seems incomplete
*
ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchRequestResponse.java
** Is it intentionally empty?
* ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
** Lets move the quartz related tables closer to rest of the tables in "ambari"
db
*
ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
** Do we need these changes?
*
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java
** Revert these changes
> Provide ability to batch requests based on schedule
> ---------------------------------------------------
>
> Key: AMBARI-4150
> URL: https://issues.apache.org/jira/browse/AMBARI-4150
> Project: Ambari
> Issue Type: Task
> Components: controller
> Affects Versions: 1.5.0
> Reporter: Siddharth Wagle
> Assignee: Siddharth Wagle
> Fix For: 1.5.0
>
> Attachments: AMBARI-4150.patch
>
>
> - Define the Request Execution Scheduler interface
> - Allow Request Executions to be scheduled based on the Request Schedules
> stored in the DB
> - Support all the batch settings available on the Request Schedule
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
