[ 
https://issues.apache.org/jira/browse/AMBARI-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864548#comment-13864548
 ] 

Siddharth Wagle commented on AMBARI-4150:
-----------------------------------------

Thanks for the feedback. Few concerns addressed below:

- "Scheduler unavailable."
This is a preemptive abort, since a scheduler instances that is shutdown cannot 
be started again, so server needs to be restarted. This ensures that we do not 
start creating jobs / triggers and then fail.
Agree that exception message can be improved.

-  If any exception is thrown in the method (scheduleBatch) then how does 
RequestExecution recover?
A chain of request will execute based on schedule even if the previous request 
failed or was aborted midway, the last_execution_status is meant to capture the 
status of the previous chain of requests.

- Is there a validation somewhere to ensure that batch orderIds are unique 
within the batch?
org.apache.ambari.server.controller.internal.RequestScheduleResourceProvider#validateRequest

- synchronized Long executeBatchRequest() - seems incomplete
This will be addressed in the followup Jira which enables request execution.

- 
ambari-server/src/main/java/org/apache/ambari/server/state/scheduler/BatchRequestResponse.java
Yes, same as above

- ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
Done

- 
ambari-server/src/test/java/org/apache/ambari/server/orm/InMemoryDefaultTestModule.java
Unnecessary imports added by previous patch reverted.

- 
ambari-server/src/test/java/org/apache/ambari/server/state/ConfigGroupTest.java 
Formatting change.




> Provide ability to batch requests based on schedule
> ---------------------------------------------------
>
>                 Key: AMBARI-4150
>                 URL: https://issues.apache.org/jira/browse/AMBARI-4150
>             Project: Ambari
>          Issue Type: Task
>          Components: controller
>    Affects Versions: 1.5.0
>            Reporter: Siddharth Wagle
>            Assignee: Siddharth Wagle
>             Fix For: 1.5.0
>
>         Attachments: AMBARI-4150-1.patch, AMBARI-4150.patch
>
>
> - Define the Request Execution Scheduler interface
> - Allow Request Executions to be scheduled based on the Request Schedules 
> stored in the DB
> - Support all the batch settings available on the Request Schedule



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to