[
https://issues.apache.org/jira/browse/AMBARI-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140280#comment-14140280
]
Andrii Tkach commented on AMBARI-7400:
--------------------------------------
+1 for the patch.
> Slider View: Most view parameters should be made required
> ---------------------------------------------------------
>
> Key: AMBARI-7400
> URL: https://issues.apache.org/jira/browse/AMBARI-7400
> Project: Ambari
> Issue Type: Bug
> Components: contrib
> Affects Versions: 1.7.0
> Reporter: Oleg Nechiporenko
> Assignee: Oleg Nechiporenko
> Priority: Critical
> Fix For: 1.7.0
>
> Attachments: AMBARI-7400.patch
>
>
> First, we should rename view parameters to below. Also we should mark them
> required as mentioned below.
> * {{hdfs.url}}. Required = true
> * {{yarn.rm.url}}. Required = true
> * {{yarn.rm.scheduler.url}}. Required = true
> * {{zookeeper.quorum}}. Required = true
> * {{ganglia.host}}. Required = *false*
> * {{ganglia.addtional.clusters}}. Required = *false*
> * {{slider.user}}. Required = *false* (see BUG-23250)
> The code on client to automatically load from Ambari should be cleaned away.
> On app load, the view should validate the parameters and display error
> messages in an error section. If there are errors (invalid values, empty
> strings, etc.), the App should be put in error mode where it does not load
> further.
> There should be an App wide location to easily determine parameters and their
> values (Maybe a _App.ViewParameter.sliderUser_ etc.).
> In the Create App wizard, _Enable Metrics_ action should only be enabled only
> when {{ganglia.addtional.clusters}} and {{ganglia.host}} are provided.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
