[ 
https://issues.apache.org/jira/browse/AMBARI-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140306#comment-14140306
 ] 

Hudson commented on AMBARI-7400:
--------------------------------

SUCCESS: Integrated in Ambari-trunk-Commit #306 (See 
[https://builds.apache.org/job/Ambari-trunk-Commit/306/])
AMBARI-7400. Slider View: Most view parameters should be made required. 
(onechiporenko) (onechiporenko: 
http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=d62147ed37864f7f9f321448c3036ade0eeb681f)
* 
contrib/views/slider/src/main/resources/ui/app/controllers/slider_controller.js
* contrib/views/slider/src/main/resources/view.xml
* 
contrib/views/slider/src/main/resources/ui/app/templates/slider_title_tooltip.hbs
* contrib/views/slider/src/main/resources/ui/config.js
* contrib/views/slider/src/main/resources/ui/app/views/application_view.js
* contrib/views/slider/src/main/resources/ui/app/templates/application.hbs
* 
contrib/views/slider/src/main/resources/ui/app/assets/data/resource/empty_json.json
* contrib/views/slider/src/main/resources/ui/app/helpers/ajax.js
* 
contrib/views/slider/src/main/resources/ui/app/controllers/createAppWizard/step1_controller.js
* 
contrib/views/slider/src/main/resources/ui/app/assets/data/resource/service_configs.json
* contrib/views/slider/src/main/resources/ui/app/mappers/slider_apps_mapper.js
* contrib/views/slider/src/main/resources/ui/app/initialize.js
* 
contrib/views/slider/src/main/resources/ui/app/assets/data/resource/cluster_name.json
* contrib/views/slider/src/main/resources/ui/app/models/slider_config.js
* contrib/views/slider/src/main/resources/ui/app/translations.js
* contrib/views/slider/src/main/resources/ui/vendor/scripts/common/tv4.js
* 
contrib/views/slider/src/main/resources/ui/app/assets/data/resource/slider-properties.json
* 
contrib/views/slider/src/main/resources/ui/app/assets/data/resource/service_status.json
* 
contrib/views/slider/src/main/resources/ui/app/assets/data/resource/components_hosts.json
* contrib/views/slider/src/main/resources/ui/app/routes/main.js


> Slider View: Most view parameters should be made required
> ---------------------------------------------------------
>
>                 Key: AMBARI-7400
>                 URL: https://issues.apache.org/jira/browse/AMBARI-7400
>             Project: Ambari
>          Issue Type: Bug
>          Components: contrib
>    Affects Versions: 1.7.0
>            Reporter: Oleg Nechiporenko
>            Assignee: Oleg Nechiporenko
>            Priority: Critical
>             Fix For: 1.7.0
>
>         Attachments: AMBARI-7400.patch
>
>
> First, we should rename view parameters to below. Also we should mark them 
> required as mentioned below.
> * {{hdfs.url}}. Required = true
> * {{yarn.rm.url}}. Required = true
> * {{yarn.rm.scheduler.url}}. Required = true
> * {{zookeeper.quorum}}. Required = true
> * {{ganglia.host}}. Required = *false*
> * {{ganglia.addtional.clusters}}. Required = *false*
> * {{slider.user}}. Required = *false* (see BUG-23250)
> The code on client to automatically load from Ambari should be cleaned away. 
> On app load, the view should validate the parameters and display error 
> messages in an error section. If there are errors (invalid values, empty 
> strings, etc.), the App should be put in error mode where it does not load 
> further.
> There should be an App wide location to easily determine parameters and their 
> values (Maybe a _App.ViewParameter.sliderUser_ etc.). 
> In the Create App wizard, _Enable Metrics_ action should only be enabled only 
> when {{ganglia.addtional.clusters}} and {{ganglia.host}} are provided.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to