> On April 21, 2015, 8:11 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/META-INF/persistence.xml, lines 91-94 > > <https://reviews.apache.org/r/33405/diff/1/?file=938438#file938438line91> > > > > Configuration has the following properties, which default to some good > > starting values. > > ``` > > public static final String SERVER_JDBC_CONNECTION_POOL = > > "server.jdbc.connection-pool"; > > public static final String SERVER_JDBC_CONNECTION_POOL_MIN_SIZE = > > "server.jdbc.connection-pool.min-size"; > > public static final String SERVER_JDBC_CONNECTION_POOL_MAX_SIZE = > > "server.jdbc.connection-pool.max-size"; > > public static final String > > SERVER_JDBC_CONNECTION_POOL_AQUISITION_SIZE = > > "server.jdbc.connection-pool.acquisition-size"; > > public static final String SERVER_JDBC_CONNECTION_POOL_MAX_AGE = > > "server.jdbc.connection-pool.max-age"; > > public static final String SERVER_JDBC_CONNECTION_POOL_MAX_IDLE_TIME > > = "server.jdbc.connection-pool.max-idle-time"; > > public static final String > > SERVER_JDBC_CONNECTION_POOL_MAX_IDLE_TIME_EXCESS = > > "server.jdbc.connection-pool.max-idle-time-excess"; > > public static final String > > SERVER_JDBC_CONNECTION_POOL_IDLE_TEST_INTERVAL = > > "server.jdbc.connection-pool.idle-test-interval"; > > ``` > > > > We should instead read these values from ambari.properties and set them > > on EclipseLink manually. > > > > Sequence values can probably remain coded as they are.
+1 for setting sequence pool though confgiuration but I do not see anybody chanigng these, do you? The db connection pool settings would definitely change, not sure about sequence pool. In any case ability to override is definitely better. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33405/#review81054 ----------------------------------------------------------- On April 21, 2015, 8:05 p.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33405/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 8:05 p.m.) > > > Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, > Jonathan Hurley, Jayush Luniya, and Sid Wagle. > > > Bugs: AMBARI-10637 > https://issues.apache.org/jira/browse/AMBARI-10637 > > > Repository: ambari > > > Description > ------- > > Split the Eclipselink sequence connection pool away from the main one. > > > Diffs > ----- > > ambari-server/src/main/resources/META-INF/persistence.xml > b864c591796967f7471e65ebbc995f8aabd2bed5 > > Diff: https://reviews.apache.org/r/33405/diff/ > > > Testing > ------- > > mvn clean install > > deployed in a local VM cluster -> no repro > > > Thanks, > > Florian Barca > >
