> On April 23, 2015, 10:56 a.m., Jonathan Hurley wrote: > > Why are separate tables only need for alerts and widgets. These business > > objects should not be creating many records apart from the initial seeding > > on cluster deploy. It seems like we're working around a problem here > > instead of fixing it. > > Florian Barca wrote: > It's not about the number of records, it's about the contention on those > records, which in SQL Server's case translates into contention on the whole > table. The Alerts are quite intensive, the sequence id goes up rapidly over > 100 after only 1 deployment.
I disagree that 100 rows is "intensive" ... we're talking enterprise level databases here. If 100 rows causes this many problems, and the only way to solve it separate sequence tables, then we need to solve the problem for all of Ambari - creating new tables for every sequence row. That's why I'm not sure this is the right way to go. Additionally, this patch does not address upgrade scenarios and starting from IDs that won't conflict existing alerts in the system. If this is the going to be the way to go (which I'm still not convinced), then we'd need proper upgrade code as well. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33405/#review81314 ----------------------------------------------------------- On April 23, 2015, 1:05 a.m., Florian Barca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33405/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 1:05 a.m.) > > > Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Ivan Kozlov, > Jonathan Hurley, Jayush Luniya, and Sid Wagle. > > > Bugs: AMBARI-10637 > https://issues.apache.org/jira/browse/AMBARI-10637 > > > Repository: ambari > > > Description > ------- > > Split the Eclipselink sequence connection pool away from the main one. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > bbeca38410aff6d452204319e42fbbd141ed7116 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 184c8dbaf944517f0ba6643fe1a2d16d244c24db > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertCurrentEntity.java > 66aa1194df5565e123146d312095dcbe79e84a57 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertDefinitionEntity.java > 6838983f16505f92a8dcae42bdc0ba0dde082544 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java > 9efb1660603d47f7a3c992f0e3ad76aa35e8ade5 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertHistoryEntity.java > 8e96aca4fcd13cf7230f890922c72d6817f759e2 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertNoticeEntity.java > ae43dfe5f61ecfe9ffcbd1b6bcc1b12b642c6906 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java > 29f79d71bb3bce38d3b2da9c033aa4346a590c49 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetEntity.java > 82d9a158a6b3fbbc0fa7f7de063af4a44d2526fe > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/WidgetLayoutEntity.java > 6ba14e4ba4fa45814755c8702b56b843d07dea52 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql > b6f2aaab9aee3879a140f4e24ae064ddccae9391 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql > 25685e50feba0b6c19d8ed0944d2a8dc31d017ae > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql > 9ade56fa047cd6b0060627e5368a8daab048a54e > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > feaeae9aedf8c454979369ed4a05ea3ebff121af > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > 03f1ec88fbc03da43dade8bb3605c28d6952d582 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql > 8cb3132a4306f099419823d9a1ed718c5a42f5a5 > ambari-server/src/main/resources/META-INF/persistence.xml > b864c591796967f7471e65ebbc995f8aabd2bed5 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 63447cad745ea04901671ec66c10716ef5c3fe5c > > Diff: https://reviews.apache.org/r/33405/diff/ > > > Testing > ------- > > mvn clean install > > deployed in a local VM cluster -> no repro > > > Thanks, > > Florian Barca > >
