----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33404/#review81057 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py <https://reviews.apache.org/r/33404/#comment131277> Duplicate? See 2 rows above. ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py <https://reviews.apache.org/r/33404/#comment131279> Same as above. ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py <https://reviews.apache.org/r/33404/#comment131280> Ensure that putYarnProperties doesn't clobber the existing values. Moving putYarnProperty above the super() call will simplify the scenario. ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py <https://reviews.apache.org/r/33404/#comment131281> Same as for putYarnProperty. ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py <https://reviews.apache.org/r/33404/#comment131282> Same as above. - Florian Barca On April 21, 2015, 7:51 p.m., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33404/ > ----------------------------------------------------------- > > (Updated April 21, 2015, 7:51 p.m.) > > > Review request for Ambari, Florian Barca and Jayush Luniya. > > > Bugs: AMBARI-10604 > https://issues.apache.org/jira/browse/AMBARI-10604 > > > Repository: ambari > > > Description > ------- > > [WinTP2] StackAdvisor for HDPWIN needs to be revisited > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py > ce0739d > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py > 050d43c > > Diff: https://reviews.apache.org/r/33404/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [5.579s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.868s] > [INFO] Ambari Server ..................................... SUCCESS [1:30.087s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Artem Baranchuk > >
