> On Апрель 21, 2015, 8:35 п.п., Florian Barca wrote: > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py, > > line 89 > > <https://reviews.apache.org/r/33404/diff/1/?file=938434#file938434line89> > > > > Ensure that putYarnProperties doesn't clobber the existing values. > > Moving putYarnProperty above the super() call will simplify the scenario.
If you look at putProperty method you can see that it won't currupt existing properties. We don't need to reorganize it. - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33404/#review81057 ----------------------------------------------------------- On Апрель 21, 2015, 7:51 п.п., Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33404/ > ----------------------------------------------------------- > > (Updated Апрель 21, 2015, 7:51 п.п.) > > > Review request for Ambari, Florian Barca and Jayush Luniya. > > > Bugs: AMBARI-10604 > https://issues.apache.org/jira/browse/AMBARI-10604 > > > Repository: ambari > > > Description > ------- > > [WinTP2] StackAdvisor for HDPWIN needs to be revisited > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py > ce0739d > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py > 050d43c > > Diff: https://reviews.apache.org/r/33404/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Views ...................................... SUCCESS [5.579s] > [INFO] Ambari Metrics Common ............................. SUCCESS [1.868s] > [INFO] Ambari Server ..................................... SUCCESS [1:30.087s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Artem Baranchuk > >
