----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37815/#review96708 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java (line 717) <https://reviews.apache.org/r/37815/#comment152349> Isn't there another call to get the host state as healthy? ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java (line 1144) <https://reviews.apache.org/r/37815/#comment152350> perhaps we should add that the cluster version is not installing. We need to ensure that during the middle of an upgrade, there's no way to change a host from maintenance mode ON to OFF. - Alejandro Fernandez On Aug. 26, 2015, 9:37 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37815/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 9:37 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-12889 > https://issues.apache.org/jira/browse/AMBARI-12889 > > > Repository: ambari > > > Description > ------- > > When distributing a repository before an upgrade, hosts that are unhealthy > should not be included. They will be purposely skipped when creating the > distribution request. The APIs and the web client will continue to report the > same distribution status in the Stacks & Versions page. An unhealthy host > will report that it does not have the desired stack installed. > > This will be the case for hosts which are heartbeating, but are in > maintenance mode. The maintenance mode flag will indicate that the new stack > should not be distributed to the host. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 2f3e959 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > ad481f3 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 86f5f32 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 5b24edc > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > f047b33 > > Diff: https://reviews.apache.org/r/37815/diff/ > > > Testing > ------- > > Tests run: 3160, Failures: 0, Errors: 0, Skipped: 25 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 29:59 min > [INFO] Finished at: 2015-08-26T17:34:55-04:00 > [INFO] Final Memory: 35M/1253M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
