> On Aug. 27, 2015, 1:47 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, > > line 722 > > <https://reviews.apache.org/r/37815/diff/1/?file=1055311#file1055311line722> > > > > Isn't there another call to get the host state as healthy?
There might be another call that gets hosts based on their health. However, this particular usage of the term healthy refers simply to hosts not in MM, regardless of their reported health. If they are not in MM, then we consider them healthy for an upgrade and our pre-req checks will take over on any that aren't heartbeating. > On Aug. 27, 2015, 1:47 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, > > line 1148 > > <https://reviews.apache.org/r/37815/diff/1/?file=1055313#file1055313line1148> > > > > perhaps we should add that the cluster version is not installing. Ordering could be tricky if we do that. There's actually no change to the logic here from before, and since this might go into 2.1.2, I don't want to risk have some weirdo regression because we also check the cluster version. I can add it if you really think we need it; just let me know. On Aug. 27, 2015, 1:47 p.m., Jonathan Hurley wrote: > > We need to ensure that during the middle of an upgrade, there's no way to > > change a host from maintenance mode ON to OFF. I thought the web client disables host actions during an RU. If not, I agree, and I'll file a Jira for it. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37815/#review96708 ----------------------------------------------------------- On Aug. 26, 2015, 5:37 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37815/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 5:37 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-12889 > https://issues.apache.org/jira/browse/AMBARI-12889 > > > Repository: ambari > > > Description > ------- > > When distributing a repository before an upgrade, hosts that are unhealthy > should not be included. They will be purposely skipped when creating the > distribution request. The APIs and the web client will continue to report the > same distribution status in the Stacks & Versions page. An unhealthy host > will report that it does not have the desired stack installed. > > This will be the case for hosts which are heartbeating, but are in > maintenance mode. The maintenance mode flag will indicate that the new stack > should not be distributed to the host. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 2f3e959 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > ad481f3 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 86f5f32 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 5b24edc > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > f047b33 > > Diff: https://reviews.apache.org/r/37815/diff/ > > > Testing > ------- > > Tests run: 3160, Failures: 0, Errors: 0, Skipped: 25 > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 29:59 min > [INFO] Finished at: 2015-08-26T17:34:55-04:00 > [INFO] Final Memory: 35M/1253M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
