----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39926/#review105023 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py <https://reviews.apache.org/r/39926/#comment163390> This was the bug. The stage id shouldn't be part of this file, but rather, the upgrade direction. This way, attempting to downgrade will delelete the Storm local dir and recreate the file, and so will performing another upgrade to the same version. - Alejandro Fernandez On Nov. 4, 2015, 1:32 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39926/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 1:32 a.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Jayush Luniya, Nate Cole, and Swapan Shridhar. > > > Bugs: AMBARI-13688 > https://issues.apache.org/jira/browse/AMBARI-13688 > > > Repository: ambari > > > Description > ------- > > Miscellaneous bug fixes for Express Upgrade in HDP 2.2->2.3 for Storm and > Knox. > > Storm: Unable to start service because the Storm dir in the local FS and in > Zookeeper znode need to be deleted exactly once per host. > Deleting the local Storm dir was not working because the marker json file > needs to contain the upgrade direction instead of the stage id. > > Knox: simple change to the manual task message to correct the location of the > data dir, which should be /var/lib/knox/data > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 86de2ec > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py > d10e7dc > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > 677bc8d > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > d41fc36 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > f910c90 > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > 8b170e6 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 4ef129d > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 4c12470 > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py > 0600a71 > ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py > a966b89 > > Diff: https://reviews.apache.org/r/39926/diff/ > > > Testing > ------- > > Tested during Express Upgrade. > Unit tests passed, > > ---------------------------------------------------------------------- > Total run:827 > Total errors:0 > Total failures:0 > > > Thanks, > > Alejandro Fernandez > >
