> On Nov. 4, 2015, 3:43 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml, > > lines 734-752 > > <https://reviews.apache.org/r/39926/diff/1/?file=1115316#file1115316line734> > > > > Out of curiosity, Can we use a <![CDATA[ .. ]]> block here? Escaping > > this much is a bit hard to read. > > Alejandro Fernandez wrote: > Will try.
I tried this and got an error since CDATA cannot be used inside values. http://stackoverflow.com/questions/2546640/cdata-for-a-value-in-xml - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39926/#review105071 ----------------------------------------------------------- On Nov. 5, 2015, 12:29 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39926/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 12:29 a.m.) > > > Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan > Hurley, Jayush Luniya, Nate Cole, and Swapan Shridhar. > > > Bugs: AMBARI-13688 > https://issues.apache.org/jira/browse/AMBARI-13688 > > > Repository: ambari > > > Description > ------- > > Miscellaneous bug fixes for Express Upgrade in HDP 2.2->2.3 for Storm and > Knox. > > Storm: Unable to start service because the Storm dir in the local FS and in > Zookeeper znode need to be deleted exactly once per host. > Deleting the local Storm dir was not working because the marker json file > needs to contain the upgrade direction instead of the stage id. > > Knox: simple change to the manual task message to correct the location of the > data dir, which should be /var/lib/knox/data > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py > 86de2ec > > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py > d10e7dc > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml > 69be963 > > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml > 06e5859 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml > 645ec0d > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml > 8b170e6 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 016bad6 > > Diff: https://reviews.apache.org/r/39926/diff/ > > > Testing > ------- > > Tested during Express Upgrade. > Unit tests passed, > > ---------------------------------------------------------------------- > Total run:827 > Total errors:0 > Total failures:0 > > > Thanks, > > Alejandro Fernandez > >
