> On Ноя. 13, 2015, 1:51 д.п., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py, > > line 189 > > <https://reviews.apache.org/r/40221/diff/2/?file=1123966#file1123966line189> > > > > Actually, all FS that I know of allow the creation of folder on them > > through this call. So we will have no problem creating the root dir even if > > the FS is not HDFS. We can skip this change.
We should check if it's hdfs rootdir, then create HdfsDirectory, otherwise create the local FS directory. It handles pseudo-distributed mode, when config['hbase-site']['hbase.cluster.distributed'] == 'true' , but ['hbase-site']['hbase.rootdir'] == 'file:///var/....' - Dmytro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40221/#review106352 ----------------------------------------------------------- On Ноя. 12, 2015, 9:50 д.п., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40221/ > ----------------------------------------------------------- > > (Updated Ноя. 12, 2015, 9:50 д.п.) > > > Review request for Ambari, Sumit Mohanty and Sid Wagle. > > > Bugs: AMBARI-13851 > https://issues.apache.org/jira/browse/AMBARI-13851 > > > Repository: ambari > > > Description > ------- > > AMS scripts should not assume that hdfs is the protocol. > is_hbase_distributed = hbase_root_dir.startswith('hdfs://') > > or > > is_hbase_distributed = > security_params['hbase-site']['hbase.rootdir'].startswith('hdfs://') > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py > 50e363c > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/hbase.py > 9e6f2fa > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_collector.py > 00e4123 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 1c6a49f > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 7181122 > > ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py > b04e1d5 > > Diff: https://reviews.apache.org/r/40221/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 249 tests in 8.115s > > OK > ---------------------------------------------------------------------- > Total run:831 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmytro Sen > >
